From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753477Ab3KAQmE (ORCPT ); Fri, 1 Nov 2013 12:42:04 -0400 Received: from mail-wg0-f44.google.com ([74.125.82.44]:54484 "EHLO mail-wg0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752084Ab3KAQmB (ORCPT ); Fri, 1 Nov 2013 12:42:01 -0400 Message-ID: <5273D9CD.2010800@gmail.com> Date: Fri, 01 Nov 2013 17:41:49 +0100 From: Sylwester Nawrocki User-Agent: Mozilla/5.0 (X11; Linux i686; rv:11.0) Gecko/20120412 Thunderbird/11.0.1 MIME-Version: 1.0 To: Jonas Jensen CC: Sylwester Nawrocki , "linux-arm-kernel@lists.infradead.org" , Mike Turquette , linux-mips@linux-mips.org, Russell King - ARM Linux , linux-sh@vger.kernel.org, jiada_wang@mentor.com, "linux-kernel@vger.kernel.org" , kyungmin.park@samsung.com, laurent.pinchart@ideasonboard.com, uclinux-dist-devel@blackfin.uclinux.org Subject: Re: [PATCH v7 0/5] clk: clock deregistration support References: <1383076268-8984-1-git-send-email-s.nawrocki@samsung.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jonas, On 11/01/2013 02:56 PM, Jonas Jensen wrote: > Hi, > > Just letting you know, the following warning from __clk_get is now > printed, and not printed after revert (git revert > 0b35b92fb3600a2f9ca114a6142db95f760d55f5). It is recommended to quote also human readable patch summary line, so it's more immediately clear which patch you refer to. > Is the driver doing something it shouldn't be doing? I don't think so. That is a known issue, it shouldn't be happening when you apply $subject patch series onto todays -next. If it does please let me know. Is the warning still triggered when you apply this patch: http://www.spinics.net/lists/arm-kernel/msg283550.html onto next-20131031 instead of reverting ? > moxart_of_pll_clk_init() source can be found here: > http://www.spinics.net/lists/arm-kernel/msg278572.html The driver seems OK from a brief look. Thanks for the feedback. > boot log: > Uncompressing Linux... done, booting the kernel. > [ 0.000000] Booting Linux on physical CPU 0x0 > [ 0.000000] Linux version 3.12.0-rc7-next-20131031+ (i@Ildjarn) > [ 0.000000] ------------[ cut here ]------------ > [ 0.000000] WARNING: CPU: 0 PID: 0 at include/linux/kref.h:47 > __clk_get+0x54/0x68() > [ 0.000000] CPU: 0 PID: 0 Comm: swapper Not tainted > 3.12.0-rc7-next-20131031+ #1043 > [ 0.000000] [] (unwind_backtrace+0x0/0xf4) from > [] (show_stack+0x18/0x1c) > [ 0.000000] [] (show_stack+0x18/0x1c) from [] > (dump_stack+0x20/0x28) > [ 0.000000] [] (dump_stack+0x20/0x28) from [] > (warn_slowpath_common+0x64/0x84) > [ 0.000000] [] (warn_slowpath_common+0x64/0x84) from > [] (warn_slowpath_null+0x24/0x2c) > [ 0.000000] [] (warn_slowpath_null+0x24/0x2c) from > [] (__clk_get+0x54/0x68) > [ 0.000000] [] (__clk_get+0x54/0x68) from [] > (of_clk_get+0x64/0x7c) > [ 0.000000] [] (of_clk_get+0x64/0x7c) from [] > (moxart_of_pll_clk_init+0xd8/0x15c) > [ 0.000000] [] (moxart_of_pll_clk_init+0xd8/0x15c) from > [] (of_clk_init+0x48/0x70) > [ 0.000000] [] (of_clk_init+0x48/0x70) from [] > (moxart_init_time+0x14/0x1c) > [ 0.000000] [] (moxart_init_time+0x14/0x1c) from > [] (time_init+0x28/0x3c) > [ 0.000000] [] (time_init+0x28/0x3c) from [] > (start_kernel+0x1d0/0x2dc) > [ 0.000000] [] (start_kernel+0x1d0/0x2dc) from > [<00008040>] (0x8040) > [ 0.000000] ---[ end trace 3406ff24bd97382e ]--- Regards, Sylwester