* [PATCH] cpufreq: ondemand: Remove redundant return statement
@ 2013-10-31 18:27 Stratos Karafotis
2013-10-31 18:39 ` Viresh Kumar
0 siblings, 1 reply; 4+ messages in thread
From: Stratos Karafotis @ 2013-10-31 18:27 UTC (permalink / raw)
To: Rafael J. Wysocki, Viresh Kumar
Cc: cpufreq@vger.kernel.org, linux-pm@vger.kernel.org, LKML,
Henrik Nilsson
After commit dfa5bb622555d9da0df21b50f46ebdeef390041b
"cpufreq: ondemand: Change the calculation of target frequency",
this return statement is no longer needed.
Reported-by: Henrik Nilsson <Karl.Henrik.Nilsson@gmail.com>
Signed-off-by: Stratos Karafotis <stratosk@semaphore.gr>
---
drivers/cpufreq/cpufreq_ondemand.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/cpufreq/cpufreq_ondemand.c b/drivers/cpufreq/cpufreq_ondemand.c
index 32f26f6..18d4091 100644
--- a/drivers/cpufreq/cpufreq_ondemand.c
+++ b/drivers/cpufreq/cpufreq_ondemand.c
@@ -168,7 +168,6 @@ static void od_check_cpu(int cpu, unsigned int load)
dbs_info->rate_mult =
od_tuners->sampling_down_factor;
dbs_freq_increase(policy, policy->max);
- return;
} else {
/* Calculate the next frequency proportional to load */
unsigned int freq_next;
--
1.8.3.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] cpufreq: ondemand: Remove redundant return statement
2013-10-31 18:27 [PATCH] cpufreq: ondemand: Remove redundant return statement Stratos Karafotis
@ 2013-10-31 18:39 ` Viresh Kumar
2013-11-01 0:18 ` Rafael J. Wysocki
0 siblings, 1 reply; 4+ messages in thread
From: Viresh Kumar @ 2013-10-31 18:39 UTC (permalink / raw)
To: Stratos Karafotis
Cc: Rafael J. Wysocki, cpufreq@vger.kernel.org,
linux-pm@vger.kernel.org, LKML, Henrik Nilsson
On 31 October 2013 23:57, Stratos Karafotis <stratosk@semaphore.gr> wrote:
> After commit dfa5bb622555d9da0df21b50f46ebdeef390041b
> "cpufreq: ondemand: Change the calculation of target frequency",
> this return statement is no longer needed.
>
> Reported-by: Henrik Nilsson <Karl.Henrik.Nilsson@gmail.com>
> Signed-off-by: Stratos Karafotis <stratosk@semaphore.gr>
> ---
> drivers/cpufreq/cpufreq_ondemand.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/cpufreq/cpufreq_ondemand.c b/drivers/cpufreq/cpufreq_ondemand.c
> index 32f26f6..18d4091 100644
> --- a/drivers/cpufreq/cpufreq_ondemand.c
> +++ b/drivers/cpufreq/cpufreq_ondemand.c
> @@ -168,7 +168,6 @@ static void od_check_cpu(int cpu, unsigned int load)
> dbs_info->rate_mult =
> od_tuners->sampling_down_factor;
> dbs_freq_increase(policy, policy->max);
> - return;
> } else {
> /* Calculate the next frequency proportional to load */
> unsigned int freq_next;
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] cpufreq: ondemand: Remove redundant return statement
2013-10-31 18:39 ` Viresh Kumar
@ 2013-11-01 0:18 ` Rafael J. Wysocki
2013-11-01 18:13 ` Stratos Karafotis
0 siblings, 1 reply; 4+ messages in thread
From: Rafael J. Wysocki @ 2013-11-01 0:18 UTC (permalink / raw)
To: Viresh Kumar
Cc: Stratos Karafotis, cpufreq@vger.kernel.org,
linux-pm@vger.kernel.org, LKML, Henrik Nilsson
On Friday, November 01, 2013 12:09:16 AM Viresh Kumar wrote:
> On 31 October 2013 23:57, Stratos Karafotis <stratosk@semaphore.gr> wrote:
> > After commit dfa5bb622555d9da0df21b50f46ebdeef390041b
> > "cpufreq: ondemand: Change the calculation of target frequency",
> > this return statement is no longer needed.
> >
> > Reported-by: Henrik Nilsson <Karl.Henrik.Nilsson@gmail.com>
> > Signed-off-by: Stratos Karafotis <stratosk@semaphore.gr>
> > ---
> > drivers/cpufreq/cpufreq_ondemand.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/cpufreq/cpufreq_ondemand.c b/drivers/cpufreq/cpufreq_ondemand.c
> > index 32f26f6..18d4091 100644
> > --- a/drivers/cpufreq/cpufreq_ondemand.c
> > +++ b/drivers/cpufreq/cpufreq_ondemand.c
> > @@ -168,7 +168,6 @@ static void od_check_cpu(int cpu, unsigned int load)
> > dbs_info->rate_mult =
> > od_tuners->sampling_down_factor;
> > dbs_freq_increase(policy, policy->max);
> > - return;
> > } else {
> > /* Calculate the next frequency proportional to load */
> > unsigned int freq_next;
>
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Queued up for 3.13, thanks!
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] cpufreq: ondemand: Remove redundant return statement
2013-11-01 0:18 ` Rafael J. Wysocki
@ 2013-11-01 18:13 ` Stratos Karafotis
0 siblings, 0 replies; 4+ messages in thread
From: Stratos Karafotis @ 2013-11-01 18:13 UTC (permalink / raw)
To: Rafael J. Wysocki, Viresh Kumar
Cc: cpufreq@vger.kernel.org, linux-pm@vger.kernel.org, LKML,
Henrik Nilsson
On 11/01/2013 02:18 AM, Rafael J. Wysocki wrote:
> On Friday, November 01, 2013 12:09:16 AM Viresh Kumar wrote:
>> On 31 October 2013 23:57, Stratos Karafotis <stratosk@semaphore.gr> wrote:
>>> After commit dfa5bb622555d9da0df21b50f46ebdeef390041b
>>> "cpufreq: ondemand: Change the calculation of target frequency",
>>> this return statement is no longer needed.
>>>
>>> Reported-by: Henrik Nilsson <Karl.Henrik.Nilsson@gmail.com>
>>> Signed-off-by: Stratos Karafotis <stratosk@semaphore.gr>
>>> ---
>>> drivers/cpufreq/cpufreq_ondemand.c | 1 -
>>> 1 file changed, 1 deletion(-)
>>>
>>> diff --git a/drivers/cpufreq/cpufreq_ondemand.c b/drivers/cpufreq/cpufreq_ondemand.c
>>> index 32f26f6..18d4091 100644
>>> --- a/drivers/cpufreq/cpufreq_ondemand.c
>>> +++ b/drivers/cpufreq/cpufreq_ondemand.c
>>> @@ -168,7 +168,6 @@ static void od_check_cpu(int cpu, unsigned int load)
>>> dbs_info->rate_mult =
>>> od_tuners->sampling_down_factor;
>>> dbs_freq_increase(policy, policy->max);
>>> - return;
>>> } else {
>>> /* Calculate the next frequency proportional to load */
>>> unsigned int freq_next;
>>
>> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
>
> Queued up for 3.13, thanks!
>
Thank you both for your immediate response!
Stratos
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-11-01 18:13 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-31 18:27 [PATCH] cpufreq: ondemand: Remove redundant return statement Stratos Karafotis
2013-10-31 18:39 ` Viresh Kumar
2013-11-01 0:18 ` Rafael J. Wysocki
2013-11-01 18:13 ` Stratos Karafotis
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox