Re: linux-next: Tree for Oct 31 (input & leds)

Randy Dunlap
2013-11-01T02:03:14Z

On 10/31/13 18:21, Samuel Thibault wrote:
> Randy Dunlap, le Thu 31 Oct 2013 11:04:59 -0700, a écrit :
>> On 10/31/13 03:00, Stephen Rothwell wrote:
>>> Hi all,
>>>
>>> Changes since 20131030:
>>>
>>> The net-next tree gained a conflict against the net tree.
>>>
>>> The devicetree tree gained a conflict against the crypto tree.
>>>
>>> The tty tree gained a build failure so I used the version from
>>> next-20131030.
>>>
>>> The arm-soc tree gained conflicts against the devicetree tree.
>>
>>
>> on i386, when both
>> CONFIG_INPUT=m
>> CONFIG_INPUT_LEDS=m
>>
>> ERROR: "input_led_disconnect" [drivers/input/input-core.ko] undefined!
>> ERROR: "input_led_connect" [drivers/input/input-core.ko] undefined!
>>
>>
>> Full randconfig file is attached.
>
> Ah, right, in that config an export is needed, here is a patch.
>
> Samuel
>
>
>
> Export input led symbols for input core module.
>
> Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>

Acked-by: Randy Dunlap <rdunlap@infradead.org>

Thanks.

>
> --- drivers/input/leds.c.orig 2013-11-01 01:43:38.889584308 +0100
> +++ drivers/input/leds.c 2013-11-01 01:44:02.060916781 +0100
> @@ -210,6 +210,7 @@
> input_led_delete(dev);
> return error;
> }
> +EXPORT_SYMBOL_GPL(input_led_connect);
>
> /* Disconnected input device. Clean it, and deregister now-useless VT LEDs
> * and triggers. */
> @@ -241,6 +242,7 @@
> }
> mutex_unlock(&vt_led_registered_lock);
> }
> +EXPORT_SYMBOL_GPL(input_led_disconnect);
>
> MODULE_LICENSE("GPL");
> MODULE_DESCRIPTION("User LED support for input layer");
> --

--
~Randy