From: Tim Gardner <timg@tpi.com>
To: Steve French <smfrench@gmail.com>
Cc: "linux-cifs@vger.kernel.org" <linux-cifs@vger.kernel.org>,
samba-technical <samba-technical@lists.samba.org>,
LKML <linux-kernel@vger.kernel.org>,
Jeff Layton <jlayton@redhat.com>,
Steve French <sfrench@samba.org>
Subject: Re: [PATCH linux-next V2] cifs: Make big endian multiplex ID sequences monotonic on the wire
Date: Fri, 01 Nov 2013 12:04:44 -0700 [thread overview]
Message-ID: <5273FB4C.5010002@tpi.com> (raw)
In-Reply-To: <CAH2r5mt5kBDR1oZfDNVu+bd7-jf=zQ6tBm2YjKXKBwdYE+YG=w@mail.gmail.com>
On 11/01/2013 11:50 AM, Steve French wrote:
> This has a couple of obvious endian errors. I will correct your patch
> and remerge into cifs-2.6.git for-next
>
> Please always remember to run endian checks against cifs builds when
> submitting a patch (and make sure sparse is installed)
>
> e.g.
>
> make C=1 M=fs/cifs modules CF=-D__CHECK_ENDIAN__
>
Didn't know about __CHECK_ENDIAN__, but will do so in the future. Your
changes look fine.
rtg
--
Tim Gardner timg@tpi.com www.tpi.com
OR 503-601-0234 x102 MT 406-443-5357
prev parent reply other threads:[~2013-11-01 19:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-16 16:32 [PATCH linux-next V2] cifs: Make big endian multiplex ID sequences monotonic on the wire Tim Gardner
2013-10-16 20:03 ` Jeff Layton
2013-10-28 14:38 ` Steve French
2013-11-01 18:50 ` Steve French
2013-11-01 19:04 ` Tim Gardner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5273FB4C.5010002@tpi.com \
--to=timg@tpi.com \
--cc=jlayton@redhat.com \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=samba-technical@lists.samba.org \
--cc=sfrench@samba.org \
--cc=smfrench@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox