Re: [PATCH v2 5/9] usb: gadget: s3c-hsotg: enable generic phy support

Matt Porter
2013-11-02T17:53:06Z

On Sat, Nov 02, 2013 at 02:09:21PM +0100, Tomasz Figa wrote:
> Hi Matt.
>
> On Friday 01 of November 2013 15:45:54 Matt Porter wrote:
> > Adds support for the generic PHY subsystem. Generic PHY
> > support is probed and then the driver falls back to checking
> > for an old style USB PHY and pdata if not found.
> >
> > Signed-off-by: Matt Porter <matt.porter@linaro.org>
> > ---
> > drivers/usb/gadget/s3c-hsotg.c | 54
> > ++++++++++++++++++++++++++++-------------- 1 file changed, 36
> > insertions(+), 18 deletions(-)
>
> Patches that convert the driver to generic PHY have been already posted by
> Kamil Debski, as a part of a series[1] adding generic PHY drivers for S5P
> and Exynos SoCs. After that series, there will be no need to support the
> usb_phy subsystem in this driver anymore.
>
> [1] http://www.mail-archive.com/linux-usb@vger.kernel.org/msg31189.html

Very nice...embarassing I somehow missed that last week. I deliberately
avoided removing that USB PHY support simply because I wanted to leave
the Samsung phy conversions to somebody else with hardware to test. ;)

I'll drop this patch and rebase on top of that series...thanks for
pointing it out.

-Matt