From: Cody P Schafer <cody@linux.vnet.ibm.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>,
Ingo Molnar <mingo@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/8] trace/trace_stat: use rbtree postorder iteration helper instead of opencoding
Date: Mon, 04 Nov 2013 00:49:21 -0800 [thread overview]
Message-ID: <52775F91.5070305@linux.vnet.ibm.com> (raw)
In-Reply-To: <20131101224538.7fe04ba8@gandalf.local.home>
On 11/01/2013 07:45 PM, Steven Rostedt wrote:
> On Fri, 1 Nov 2013 15:38:46 -0700
> Cody P Schafer <cody@linux.vnet.ibm.com> wrote:
>
>> Use rbtree_postorder_for_each_entry_safe() to destroy the rbtree instead
>> of opencoding an alternate postorder iteration that modifies the tree
>>
>> Signed-off-by: Cody P Schafer <cody@linux.vnet.ibm.com>
>> ---
>> kernel/trace/trace_stat.c | 42 ++++++------------------------------------
>> 1 file changed, 6 insertions(+), 36 deletions(-)
>>
>> + rbtree_postorder_for_each_entry_safe(snode, n, &session->stat_root,
>> + node) {
>
> This is one of those cases that a line break is uglier than keeping it
> on the same line. Heck, it's only 4 characters over the 80 char limit.
>
I'm fine with that being tweaked.
> Other than that, I'm fine with this patch. Want me to take this
> separately?
>
The patches in this patchset are all independent (they just happen to be
making nearly identical changes throughout the tree), so feel free.
next prev parent reply other threads:[~2013-11-04 8:49 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-01 22:38 [PATCH 1/8] net ipset: use rbtree postorder iteration instead of opencoding Cody P Schafer
2013-11-01 22:38 ` [PATCH 2/8] trace/trace_stat: use rbtree postorder iteration helper " Cody P Schafer
2013-11-02 2:45 ` Steven Rostedt
2013-11-04 8:49 ` Cody P Schafer [this message]
2013-11-04 14:22 ` Steven Rostedt
2013-11-01 22:38 ` [PATCH 3/8] fs/ubifs: " Cody P Schafer
2013-11-01 22:38 ` [PATCH 4/8] fs/ext4: " Cody P Schafer
2013-11-01 22:38 ` [PATCH 5/8] fs/jffs2: " Cody P Schafer
2013-11-01 22:38 ` [PATCH 6/8] fs/ext3: " Cody P Schafer
2013-11-04 14:26 ` Jan Kara
2013-11-05 0:45 ` Jan Kara
2013-11-05 1:33 ` Cody P Schafer
2013-11-05 1:40 ` [PATCH 1/2] rbtree: fix postorder iteration when the rb_node is not the first element in an entry Cody P Schafer
2013-11-05 1:40 ` [PATCH 2/2] rbtree/test: move rb_node to the middle of the test struct Cody P Schafer
2013-11-05 10:05 ` [PATCH 1/2] rbtree: fix postorder iteration when the rb_node is not the first element in an entry Cody P Schafer
2013-11-05 21:57 ` Jan Kara
2013-11-05 22:56 ` Jan Kara
2013-11-06 20:18 ` Cody P Schafer
2013-11-06 21:37 ` [PATCH] rbtree/test: test rbtree_postorder_for_each_entry_safe() Cody P Schafer
2013-11-06 23:16 ` Andrew Morton
2013-11-01 22:38 ` [PATCH 7/8] mtd/ubi: use rbtree postorder iteration helper instead of opencoding Cody P Schafer
2013-11-01 22:38 ` [PATCH 8/8] sh/dwarf: use rbtree postorder iteration helper instead of solution using repeated rb_erase() Cody P Schafer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52775F91.5070305@linux.vnet.ibm.com \
--to=cody@linux.vnet.ibm.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox