From: Michael Opdenacker <michael.opdenacker@free-electrons.com>
To: Heiko Carstens <heiko.carstens@de.ibm.com>
Cc: schwidefsky@de.ibm.com, linux390@de.ibm.com,
linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] s390: remove unused Kconfig parameters
Date: Mon, 04 Nov 2013 15:58:49 +0100 [thread overview]
Message-ID: <5277B629.9060108@free-electrons.com> (raw)
In-Reply-To: <20131104110849.GA4117@osiris>
Hi Heiko,
Thank you for reviewing my patch!
On 11/04/2013 12:08 PM, Heiko Carstens wrote:
> On Mon, Nov 04, 2013 at 10:43:39AM +0100, Michael Opdenacker wrote:
>> This removes the HAVE_MARCH_Z900_FEATURES and
>> HAVE_MARCH_Z990_FEATURES Kconfig parameters,
>> which were no longer used anywhere in the source code
>> and Makefiles.
>>
>> Actually, HAVE_MARCH_Z990_FEATURES is no longer used
>> after removing HAVE_MARCH_Z900_FEATURES.
>>
>> Signed-off-by: Michael Opdenacker <michael.opdenacker@free-electrons.com>
> Thanks for the patch. However each architecture generation is supposed to
> have its own "HAVE_MARCH_*" config.
> Even if its not used right now, it might create problems in the future
> if they are only partially present.
> So I'm not going to apply your patch.
I understand. No problem. That's your choice as a maintainer. I'm just
trying to help :)
Thanks again,
Michael.
--
Michael Opdenacker, CEO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
+33 484 258 098
prev parent reply other threads:[~2013-11-04 14:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-04 9:43 [PATCH] s390: remove unused Kconfig parameters Michael Opdenacker
2013-11-04 11:08 ` Heiko Carstens
2013-11-04 14:58 ` Michael Opdenacker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5277B629.9060108@free-electrons.com \
--to=michael.opdenacker@free-electrons.com \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux390@de.ibm.com \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox