[PATCH] s390: remove unused Kconfig parameters

[PATCH] s390: remove unused Kconfig parameters

[Michael Opdenacker]

This removes the HAVE_MARCH_Z900_FEATURES and
HAVE_MARCH_Z990_FEATURES Kconfig parameters,
which were no longer used anywhere in the source code
and Makefiles.

Actually, HAVE_MARCH_Z990_FEATURES is no longer used
after removing HAVE_MARCH_Z900_FEATURES.

Signed-off-by: Michael Opdenacker <michael.opdenacker@free-electrons.com>
---
 arch/s390/Kconfig | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/arch/s390/Kconfig b/arch/s390/Kconfig
index 7143793859fa..df2182d35376 100644
--- a/arch/s390/Kconfig
+++ b/arch/s390/Kconfig
@@ -153,16 +153,8 @@ source "kernel/Kconfig.freezer"
 
 menu "Processor type and features"
 
-config HAVE_MARCH_Z900_FEATURES
-	def_bool n
-
-config HAVE_MARCH_Z990_FEATURES
-	def_bool n
-	select HAVE_MARCH_Z900_FEATURES
-
 config HAVE_MARCH_Z9_109_FEATURES
 	def_bool n
-	select HAVE_MARCH_Z990_FEATURES
 
 config HAVE_MARCH_Z10_FEATURES
 	def_bool n
@@ -189,7 +181,6 @@ config MARCH_G5
 
 config MARCH_Z900
 	bool "IBM zSeries model z800 and z900"
-	select HAVE_MARCH_Z900_FEATURES if 64BIT
 	help
 	  Select this to enable optimizations for model z800/z900 (2064 and
 	  2066 series). This will enable some optimizations that are not
@@ -197,7 +188,6 @@ config MARCH_Z900
 
 config MARCH_Z990
 	bool "IBM zSeries model z890 and z990"
-	select HAVE_MARCH_Z990_FEATURES if 64BIT
 	help
 	  Select this to enable optimizations for model z890/z990 (2084 and
 	  2086 series). The kernel will be slightly faster but will not work
-- 
1.8.1.2

Re: [PATCH] s390: remove unused Kconfig parameters

[Heiko Carstens]

On Mon, Nov 04, 2013 at 10:43:39AM +0100, Michael Opdenacker wrote:
> This removes the HAVE_MARCH_Z900_FEATURES and
> HAVE_MARCH_Z990_FEATURES Kconfig parameters,
> which were no longer used anywhere in the source code
> and Makefiles.
> 
> Actually, HAVE_MARCH_Z990_FEATURES is no longer used
> after removing HAVE_MARCH_Z900_FEATURES.
> 
> Signed-off-by: Michael Opdenacker <michael.opdenacker@free-electrons.com>

Thanks for the patch. However each architecture generation is supposed to
have its own "HAVE_MARCH_*" config.
Even if its not used right now, it might create problems in the future
if they are only partially present.
So I'm not going to apply your patch.

Re: [PATCH] s390: remove unused Kconfig parameters

[Michael Opdenacker]

Hi Heiko,

Thank you for reviewing my patch!

On 11/04/2013 12:08 PM, Heiko Carstens wrote:
> On Mon, Nov 04, 2013 at 10:43:39AM +0100, Michael Opdenacker wrote:
>> This removes the HAVE_MARCH_Z900_FEATURES and
>> HAVE_MARCH_Z990_FEATURES Kconfig parameters,
>> which were no longer used anywhere in the source code
>> and Makefiles.
>>
>> Actually, HAVE_MARCH_Z990_FEATURES is no longer used
>> after removing HAVE_MARCH_Z900_FEATURES.
>>
>> Signed-off-by: Michael Opdenacker <michael.opdenacker@free-electrons.com>
> Thanks for the patch. However each architecture generation is supposed to
> have its own "HAVE_MARCH_*" config.
> Even if its not used right now, it might create problems in the future
> if they are only partially present.
> So I'm not going to apply your patch.
I understand. No problem. That's your choice as a maintainer. I'm just
trying to help :)

Thanks again,

Michael.

-- 
Michael Opdenacker, CEO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
+33 484 258 098