From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753905Ab3KDO7A (ORCPT ); Mon, 4 Nov 2013 09:59:00 -0500 Received: from top.free-electrons.com ([176.31.233.9]:34698 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753874Ab3KDO66 (ORCPT ); Mon, 4 Nov 2013 09:58:58 -0500 Message-ID: <5277B629.9060108@free-electrons.com> Date: Mon, 04 Nov 2013 15:58:49 +0100 From: Michael Opdenacker User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 MIME-Version: 1.0 To: Heiko Carstens CC: schwidefsky@de.ibm.com, linux390@de.ibm.com, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] s390: remove unused Kconfig parameters References: <1383558219-5223-1-git-send-email-michael.opdenacker@free-electrons.com> <20131104110849.GA4117@osiris> In-Reply-To: <20131104110849.GA4117@osiris> X-Enigmail-Version: 1.5.2 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Heiko, Thank you for reviewing my patch! On 11/04/2013 12:08 PM, Heiko Carstens wrote: > On Mon, Nov 04, 2013 at 10:43:39AM +0100, Michael Opdenacker wrote: >> This removes the HAVE_MARCH_Z900_FEATURES and >> HAVE_MARCH_Z990_FEATURES Kconfig parameters, >> which were no longer used anywhere in the source code >> and Makefiles. >> >> Actually, HAVE_MARCH_Z990_FEATURES is no longer used >> after removing HAVE_MARCH_Z900_FEATURES. >> >> Signed-off-by: Michael Opdenacker > Thanks for the patch. However each architecture generation is supposed to > have its own "HAVE_MARCH_*" config. > Even if its not used right now, it might create problems in the future > if they are only partially present. > So I'm not going to apply your patch. I understand. No problem. That's your choice as a maintainer. I'm just trying to help :) Thanks again, Michael. -- Michael Opdenacker, CEO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com +33 484 258 098