From: Romain Naour <romain.naour@openwide.fr>
To: Darren Hart <darren@dvhart.com>,
Johannes Berg <johannes@sipsolutions.net>
Cc: Steven Rostedt <rostedt@goodmis.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/1] trace-cmd: use pkg-config instead of python-config
Date: Tue, 05 Nov 2013 00:02:05 +0100 [thread overview]
Message-ID: <5278276D.3040200@openwide.fr> (raw)
In-Reply-To: <CAGChsmM39v=CLKD5=s5AmFGtpAbsM6KQQ-9K-=Kvis+6SM=ZMw@mail.gmail.com>
Hi,
Le 04/11/2013 23:20, Darren Hart a écrit :
> I'm hardly an expert here, but the appears sane to me. Perhaps a
> comment above the PYTHON_VERS describing what valid values are would
> be helpful. Otherwise, looks good to me.
Expected values are "python" and "python3" for PYTHON_VERS.
trace-cmd has been added in buildroot right after the 2013.08 release,
but several build failures has occurred in autobuilder like this one:
http://autobuild.buildroot.net/results/980/980875810528ac1dee34b8c268d9b3c40b2e35ec/build-end.log
Currently, we have two separate package for python2 and python3 in buildroot,
that's why I use PYTHON_VERS here.
See how trace-cmd.mk use PYTHON_VERS:
http://git.buildroot.net/buildroot/commit/?id=ff0367008c683362f422751644237218b1c45def
Best regards,
Romain Naour
>
> On Mon, Nov 4, 2013 at 12:32 AM, Johannes Berg
> <johannes@sipsolutions.net> wrote:
>> On Fri, 2013-11-01 at 17:19 -0400, Steven Rostedt wrote:
>>> Please Cc me on trace-cmd patches.
>>>
>>> Johannes and Darren,
>>>
>>> Since you handle the python bindings in trace-cmd, can you give me an
>>> ack or nack.
>>
>> Looks fine to me, in that it would work on my system :)
>>
>> johannes
>>
>
>
>
prev parent reply other threads:[~2013-11-04 23:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-31 17:39 [PATCH 1/1] trace-cmd: use pkg-config instead of python-config Romain Naour
2013-11-01 21:19 ` Steven Rostedt
2013-11-04 8:32 ` Johannes Berg
2013-11-04 22:20 ` Darren Hart
2013-11-04 23:02 ` Romain Naour [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5278276D.3040200@openwide.fr \
--to=romain.naour@openwide.fr \
--cc=darren@dvhart.com \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox