From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754005Ab3KECns (ORCPT ); Mon, 4 Nov 2013 21:43:48 -0500 Received: from mga02.intel.com ([134.134.136.20]:15150 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750819Ab3KECnq (ORCPT ); Mon, 4 Nov 2013 21:43:46 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.93,535,1378882800"; d="scan'208";a="403666544" Message-ID: <52785B90.4050807@intel.com> Date: Tue, 05 Nov 2013 10:44:32 +0800 From: Aaron Lu Organization: Intel, Shanghai, PRC MIME-Version: 1.0 To: Phillip Susi , linux-scsi@vger.kernel.org CC: linux-kernel@vger.kernel.org, "linux-ide@vger.kernel.org" , Tejun Heo , Robert Hancock Subject: Re: [PATCH 1/2] libata: use sleep instead of standby command References: <1383612780-6591-1-git-send-email-psusi@ubuntu.com> <527856B6.8030901@intel.com> <52785A4E.7080006@ubuntu.com> In-Reply-To: <52785A4E.7080006@ubuntu.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/05/2013 10:39 AM, Phillip Susi wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA512 > > On 11/04/2013 09:23 PM, Aaron Lu wrote: >> I suppose this is mainly for runtime PM? Since for system >> suspend/hibernation, the disk and its controller will be powered >> off anyway. > > Yes, or the second patch also helps when one manually issues hdparm > - -Y, which otherwise will cause the drive to be woken up to answer the > CHECK POWER command, which udisks issues to decide if it should skip > polling the SMART status of the drive. OK, I see. I wish udidks can do both of these(polling smart status and put the disk into sleep mode), so that it knows when the disk is in sleep mode and it will not send out the needless poll... -Aaron