From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754450Ab3KEL0O (ORCPT ); Tue, 5 Nov 2013 06:26:14 -0500 Received: from smtp.citrix.com ([66.165.176.89]:17452 "EHLO SMTP.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754164Ab3KEL0N (ORCPT ); Tue, 5 Nov 2013 06:26:13 -0500 X-IronPort-AV: E=Sophos;i="4.93,639,1378857600"; d="scan'208";a="70657015" Message-ID: <5278D5D3.1020605@citrix.com> Date: Tue, 5 Nov 2013 12:26:11 +0100 From: =?UTF-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 MIME-Version: 1.0 To: , CC: Roger Pau Monne , Matt Wilson , Konrad Rzeszutek Wilk , David Vrabel , Boris Ostrovsky Subject: Re: [PATCH] grant-table: don't set m2p override if kmap_ops is not set References: <1383650649-13971-1-git-send-email-roger.pau@citrix.com> In-Reply-To: <1383650649-13971-1-git-send-email-roger.pau@citrix.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-DLP: MIA2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/11/13 12:24, Roger Pau Monne wrote: > IMHO there's no reason to set a m2p override if the mapping is done in > kernel space, so only set the m2p override when kmap_ops is set. > > When kmap_ops is not set, just set the correct p2m translation, this > avoids touching the m2p lock, reducing contention around it. > > Signed-off-by: Roger Pau Monné > Reported-by: Matt Wilson > Cc: Matt Wilson > Cc: Konrad Rzeszutek Wilk > Cc: David Vrabel > Cc: Boris Ostrovsky Sorry Boris, I got your address wrong.