public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: David Ahern <dsahern@gmail.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: acme@ghostprotocols.net, linux-kernel@vger.kernel.org,
	Namhyung Kim <namhyung@kernel.org>, Jiri Olsa <jolsa@redhat.com>
Subject: Re: [PATCH] perf: Fix version when building out of tree
Date: Wed, 06 Nov 2013 07:54:37 -0700	[thread overview]
Message-ID: <527A582D.4000301@gmail.com> (raw)
In-Reply-To: <20131106053654.GA23746@gmail.com>

On 11/5/13, 10:36 PM, Ingo Molnar wrote:
> I think you could avoid the 'short' complication altogether by doing
> something like this:
>
>> +elif test -f ../../PERF-VERSION-FILE
>> +then
>> +	TAG=$(cut -d' ' -f3 ../../PERF-VERSION-FILE)
>
> That extracts 'TAG' as a true sha1 and makes GVF correct on out of tree
> builds as well.

Certainly. I was trying to make PERF-VERSION-FILE readable as a 
standalone file -- a better version descriptor than HEAD file.

David




  reply	other threads:[~2013-11-06 14:54 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-06  0:53 [PATCH] perf: Fix version when building out of tree David Ahern
2013-11-06  5:36 ` Ingo Molnar
2013-11-06 14:54   ` David Ahern [this message]
2013-11-07  8:30     ` Ingo Molnar
2013-11-07 14:30       ` David Ahern
2013-11-11 11:50         ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=527A582D.4000301@gmail.com \
    --to=dsahern@gmail.com \
    --cc=acme@ghostprotocols.net \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=namhyung@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox