Re: [PATCH] edac, highbank: remove dependency on ARCH_HIGHBANK

[Rob Herring <robherring2@gmail.com>]

On 11/06/2013 08:20 AM, Borislav Petkov wrote:
> On Tue, Nov 05, 2013 at 09:25:52PM -0600, Rob Herring wrote:
>> From: Rob Herring <rob.herring@calxeda.com>
>>
>> In order to enable on arm64 and improve the build coverage, remove the
>> dependency on ARCH_HIGHBANK.
>>
>> Signed-off-by: Rob Herring <rob.herring@calxeda.com>
>> Cc: Doug Thompson <dougthompson@xmission.com>
>> Cc: Robert Richter <rric@kernel.org>
>> Cc: linux-edac@vger.kernel.org
>> ---
>>  drivers/edac/Kconfig | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/edac/Kconfig b/drivers/edac/Kconfig
>> index 878f090..fc8aaaf 100644
>> --- a/drivers/edac/Kconfig
>> +++ b/drivers/edac/Kconfig
>> @@ -328,14 +328,14 @@ config EDAC_TILE
>>  
>>  config EDAC_HIGHBANK_MC
>>  	tristate "Highbank Memory Controller"
>> -	depends on EDAC_MM_EDAC && ARCH_HIGHBANK
>> +	depends on EDAC_MM_EDAC
> 
> Please, no, this'll get enabled on other arches where this driver is
> simply N/A. It should only depend on the ARM arches it supports.

Other maintainers disagree because it reduces build coverage. Having
done some cross arch clean-up, I have to agree with that position.
Iterating builds over different arches is bad enough, but iterating over
all configs for each arch is a pain. It would be nice to have a uniform
policy here.

Rob