From: Santosh Shilimkar <santosh.shilimkar@ti.com>
To: Stephen Boyd <sboyd@codeaurora.org>
Cc: <linux-arm-kernel@lists.infradead.org>,
Mahesh Sivasubramanian <msivasub@codeaurora.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ARM: Save/Restore 64-bit TTBR registers on LPAE suspend/resume
Date: Fri, 8 Nov 2013 12:04:34 -0500 [thread overview]
Message-ID: <527D19A2.5050604@ti.com> (raw)
In-Reply-To: <1383873633-2499-1-git-send-email-sboyd@codeaurora.org>
On Thursday 07 November 2013 08:20 PM, Stephen Boyd wrote:
> From: Mahesh Sivasubramanian <msivasub@codeaurora.org>
>
> LPAE enabled kernels use the 64-bit version of TTBR0 and TTBR1
> registers. If we're running an LPAE kernel, fill the upper half
> of TTBR0 with 0 because we're setting it to the idmap here (the
> idmap is guaranteed to be < 4Gb) and fully restore TTBR1 instead
> of just restoring the lower 32 bits. Failure to do so can cause
> failures on resume from suspend when these registers are only
> half restored.
>
> Signed-off-by: Mahesh Sivasubramanian <msivasub@codeaurora.org>
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
> ---
Looks like the trick of TTBR1 as discussed on irc worked for you.
Patch looks good to me.
Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
prev parent reply other threads:[~2013-11-08 17:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-08 1:20 [PATCH] ARM: Save/Restore 64-bit TTBR registers on LPAE suspend/resume Stephen Boyd
2013-11-08 17:04 ` Santosh Shilimkar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=527D19A2.5050604@ti.com \
--to=santosh.shilimkar@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=msivasub@codeaurora.org \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).