* Re: [PATCH] Staging: android: Add possibility to compile android drivers as modules
2013-11-09 13:23 [PATCH] Staging: android: Add possibility to compile android drivers as modules Baptiste Covolato
@ 2013-11-09 12:55 ` Levente Kurusa
2013-11-09 13:15 ` Baptiste Covolato
0 siblings, 1 reply; 4+ messages in thread
From: Levente Kurusa @ 2013-11-09 12:55 UTC (permalink / raw)
To: Baptiste Covolato, greg; +Cc: swetland, linux-kernel
2013-11-09 14:23 keltezéssel, Baptiste Covolato írta:
> Compilation of Android staging drivers as drivers is now possible.
'drivers as drivers'? :-)
Also, this commit message says nothing about what the patch does.
Something like this would be more appropriate:
Edit Android Kconfig files to allow building the drivers as modules.
--
Regards,
Levente Kurusa
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Staging: android: Add possibility to compile android drivers as modules
2013-11-09 12:55 ` Levente Kurusa
@ 2013-11-09 13:15 ` Baptiste Covolato
2013-11-09 13:22 ` Levente Kurusa
0 siblings, 1 reply; 4+ messages in thread
From: Baptiste Covolato @ 2013-11-09 13:15 UTC (permalink / raw)
To: levex; +Cc: Greg Kroah-Hartman, Brian Swetland, linux-kernel
Thanks for the review.
Should I repost this patch with correct git commit message here or in
another mail ?
Regards,
--
Baptiste Covolato
2013/11/9 Levente Kurusa <levex@linux.com>:
> 2013-11-09 14:23 keltezéssel, Baptiste Covolato írta:
>> Compilation of Android staging drivers as drivers is now possible.
>
> 'drivers as drivers'? :-)
>
> Also, this commit message says nothing about what the patch does.
> Something like this would be more appropriate:
> Edit Android Kconfig files to allow building the drivers as modules.
>
>
>
> --
> Regards,
> Levente Kurusa
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Staging: android: Add possibility to compile android drivers as modules
2013-11-09 13:15 ` Baptiste Covolato
@ 2013-11-09 13:22 ` Levente Kurusa
0 siblings, 0 replies; 4+ messages in thread
From: Levente Kurusa @ 2013-11-09 13:22 UTC (permalink / raw)
To: Baptiste Covolato; +Cc: Greg Kroah-Hartman, Brian Swetland, linux-kernel
2013-11-09 14:15 keltezéssel, Baptiste Covolato írta:
> Thanks for the review.
>
> Should I repost this patch with correct git commit message here or in
> another mail ?
Post it a new mail with a subject like [PATCH v2] or something among the lines.
Also, have you tested that they compile as modules and can be insmod'ed?
--
Regards,
Levente Kurusa
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] Staging: android: Add possibility to compile android drivers as modules
@ 2013-11-09 13:23 Baptiste Covolato
2013-11-09 12:55 ` Levente Kurusa
0 siblings, 1 reply; 4+ messages in thread
From: Baptiste Covolato @ 2013-11-09 13:23 UTC (permalink / raw)
To: greg; +Cc: swetland, linux-kernel, Baptiste Covolato
Compilation of Android staging drivers as drivers is now possible.
Signed-off-by: Baptiste Covolato <b.covolato@gmail.com>
---
drivers/staging/android/Kconfig | 18 +++++++++---------
drivers/staging/android/TODO | 1 -
2 files changed, 9 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/android/Kconfig b/drivers/staging/android/Kconfig
index 1e9ab6d..a22737d 100644
--- a/drivers/staging/android/Kconfig
+++ b/drivers/staging/android/Kconfig
@@ -1,7 +1,7 @@
menu "Android"
config ANDROID
- bool "Android Drivers"
+ tristate "Android Drivers"
default N
---help---
Enable support for various drivers needed on the Android platform
@@ -9,7 +9,7 @@ config ANDROID
if ANDROID
config ANDROID_BINDER_IPC
- bool "Android Binder IPC Driver"
+ tristate "Android Binder IPC Driver"
depends on MMU
default n
---help---
@@ -21,7 +21,7 @@ config ANDROID_BINDER_IPC
between said processes.
config ASHMEM
- bool "Enable the Anonymous Shared Memory Subsystem"
+ tristate "Enable the Anonymous Shared Memory Subsystem"
default n
depends on SHMEM
---help---
@@ -50,7 +50,7 @@ config ANDROID_LOGGER
much overhead in the system.
config ANDROID_TIMED_OUTPUT
- bool "Timed output class driver"
+ tristate "Timed output class driver"
default y
config ANDROID_TIMED_GPIO
@@ -59,13 +59,13 @@ config ANDROID_TIMED_GPIO
default n
config ANDROID_LOW_MEMORY_KILLER
- bool "Android Low Memory Killer"
+ tristate "Android Low Memory Killer"
default N
---help---
Registers processes to be killed when memory is low
config ANDROID_INTF_ALARM_DEV
- bool "Android alarm driver"
+ tristate "Android alarm driver"
depends on RTC_CLASS
default n
---help---
@@ -74,7 +74,7 @@ config ANDROID_INTF_ALARM_DEV
Also exports the alarm interface to user-space.
config SYNC
- bool "Synchronization framework"
+ tristate "Synchronization framework"
default n
select ANON_INODES
---help---
@@ -83,7 +83,7 @@ config SYNC
synchronization built into devices like GPUs.
config SW_SYNC
- bool "Software synchronization objects"
+ tristate "Software synchronization objects"
default n
depends on SYNC
---help---
@@ -92,7 +92,7 @@ config SW_SYNC
the synchronization.
config SW_SYNC_USER
- bool "Userspace API for SW_SYNC"
+ tristate "Userspace API for SW_SYNC"
default n
depends on SW_SYNC
---help---
diff --git a/drivers/staging/android/TODO b/drivers/staging/android/TODO
index b15fb0d..9b7394a 100644
--- a/drivers/staging/android/TODO
+++ b/drivers/staging/android/TODO
@@ -2,7 +2,6 @@ TODO:
- checkpatch.pl cleanups
- sparse fixes
- rename files to be not so "generic"
- - make sure things build as modules properly
- add proper arch dependencies as needed
- audit userspace interfaces to make sure they are sane
--
1.8.4.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-11-09 13:22 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-09 13:23 [PATCH] Staging: android: Add possibility to compile android drivers as modules Baptiste Covolato
2013-11-09 12:55 ` Levente Kurusa
2013-11-09 13:15 ` Baptiste Covolato
2013-11-09 13:22 ` Levente Kurusa
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).