public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ionut Nicu <ioan.nicu.ext@nsn.com>
To: ext Pantelis Antoniou <panto@antoniou-consulting.com>,
	Grant Likely <grant.likely@secretlab.ca>
Cc: Rob Herring <robherring2@gmail.com>,
	Stephen Warren <swarren@wwwdotorg.org>,
	Matt Porter <matt.porter@linaro.org>,
	Koen Kooi <koen@dominion.thruhere.net>,
	Alison Chaiken <Alison_Chaiken@mentor.com>,
	Dinh Nguyen <dinh.linux@gmail.com>, Jan Lubbe <jluebbe@lasnet.de>,
	Alexander Sverdlin <alexander.sverdlin@nsn.com>,
	Michael Stickel <ms@mycable.de>,
	Guenter Roeck <linux@roeck-us.net>,
	Dirk Behme <dirk.behme@gmail.com>,
	Alan Tull <delicious.quinoa@gmail.com>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Michael Bohan <mbohan@codeaurora.org>,
	Michal Simek <monstr@monstr.eu>,
	Matt Ranostay <mranostay@gmail.com>,
	Joel Becker <jlbec@evilplan.org>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 3/3] DT: proc: Add runtime overlay interface in /proc
Date: Mon, 11 Nov 2013 11:22:07 +0100	[thread overview]
Message-ID: <5280AFCF.8050208@nsn.com> (raw)
In-Reply-To: <1383923170-24914-4-git-send-email-panto@antoniou-consulting.com>

Hi,

On 08.11.2013 16:06, ext Pantelis Antoniou wrote:
> Add a runtime interface to /proc to enable generic device tree overlay
> usage.
> 

> +
> +		/* start at 256K at first */
> +		if (od->alloc == 0)
> +			od->alloc = SZ_256K / 2;
> +

Same problem as Guenter reported. I have to include <linux/sizes.h> or otherwise
the code will not build.

> +	rcu_read_lock();
> +	idr_for_each_entry(&overlay_idr, od, id) {
> +		seq_printf(m, "%d: %d bytes", id, od->size);

For od->size we should use "%zu", otherwise there will be a compilation warning.
At least I get one on mips64...

Otherwise, I've tested this and it works fine for me also.

Thanks,
Ionut

  parent reply	other threads:[~2013-11-11 10:23 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-08 15:06 [PATCH v3 0/3] Introducing Device Tree Overlays Pantelis Antoniou
2013-11-08 15:06 ` [PATCH v3 1/3] OF: Introduce Device Tree resolve support Pantelis Antoniou
2013-11-11 18:17   ` Grant Likely
2013-11-12  8:28     ` Pantelis Antoniou
2013-11-13  1:39       ` Grant Likely
2013-11-13  9:06         ` Pantelis Antoniou
2013-11-08 15:06 ` [PATCH v3 2/3] OF: Introduce DT overlay support Pantelis Antoniou
     [not found]   ` < 20131111184245.D569DC4234A@trevor.secretlab.ca>
     [not found]     ` < ED51965C-6EC8-48AE-A59C-CD09FFD57731@antoniou-consulting.com>
     [not found]       ` < 20131114013124.7DD0AC404DF@trevor.secretlab.ca>
     [not found]         ` < E4922A5F-11B3-4167-91EF-C0D5F3F77D40@antoniou-consulting.com>
     [not found]           ` < 20131114212206.EAD1BC402B4@trevor.secretlab.ca>
2013-11-08 19:12   ` Guenter Roeck
2013-11-11 18:42   ` Grant Likely
2013-11-12  9:30     ` Pantelis Antoniou
2013-11-14  1:31       ` Grant Likely
2013-11-14 10:01         ` Pantelis Antoniou
2013-11-14 21:22           ` Grant Likely
2013-11-15  8:34             ` Pantelis Antoniou
2013-11-15 16:13               ` Grant Likely
2013-11-08 15:06 ` [PATCH v3 3/3] DT: proc: Add runtime overlay interface in /proc Pantelis Antoniou
2013-11-08 20:00   ` Guenter Roeck
2013-11-11 10:22   ` Ionut Nicu [this message]
2013-11-11 12:30     ` Pantelis Antoniou
2013-11-11 18:47   ` Grant Likely
2013-11-12  8:40     ` Pantelis Antoniou
2013-11-12 15:27       ` Matt Porter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5280AFCF.8050208@nsn.com \
    --to=ioan.nicu.ext@nsn.com \
    --cc=Alison_Chaiken@mentor.com \
    --cc=alexander.sverdlin@nsn.com \
    --cc=delicious.quinoa@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dinh.linux@gmail.com \
    --cc=dirk.behme@gmail.com \
    --cc=grant.likely@secretlab.ca \
    --cc=jlbec@evilplan.org \
    --cc=jluebbe@lasnet.de \
    --cc=koen@dominion.thruhere.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=matt.porter@linaro.org \
    --cc=mbohan@codeaurora.org \
    --cc=monstr@monstr.eu \
    --cc=mranostay@gmail.com \
    --cc=ms@mycable.de \
    --cc=panto@antoniou-consulting.com \
    --cc=robherring2@gmail.com \
    --cc=s.hauer@pengutronix.de \
    --cc=swarren@wwwdotorg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox