public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Michal Marek <mmarek@suse.cz>
To: Andi Kleen <andi@firstfloor.org>
Cc: Fengguang Wu <fengguang.wu@intel.com>,
	Joe Mario <jmario@redhat.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [kallsyms] general protection fault: 0000 [#1] PREEMPT DEBUG_PAGEALLOC
Date: Mon, 11 Nov 2013 13:07:22 +0100	[thread overview]
Message-ID: <5280C87A.5050606@suse.cz> (raw)
In-Reply-To: <20131110152338.GN29695@two.firstfloor.org>

On 10.11.2013 16:23, Andi Kleen wrote:
> On Sun, Nov 10, 2013 at 05:40:05PM +0800, Fengguang Wu wrote:
>> Hi Joe,
>>
>> FYI. Here is another bisect result.
> 
> I bet it's that strncpy() in kallsyms.c and someone passing in a too
> short buffer on a 32bit kernel.
> 
> We should really kill strncpy(), it's just evil.

I'm testing a patch for include/linux/pci.h to use line numbers instead
of the PCI ID macros to declare the __pci_fixup_* symbols. If that
works, we can revert the limit back to 128 and only keep the check in
kallsyms.c.

Michal

  reply	other threads:[~2013-11-11 12:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-10  9:40 [kallsyms] general protection fault: 0000 [#1] PREEMPT DEBUG_PAGEALLOC Fengguang Wu
2013-11-10 15:23 ` Andi Kleen
2013-11-11 12:07   ` Michal Marek [this message]
2013-11-11 13:27     ` Joe Mario
2013-11-11 14:12       ` Michal Marek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5280C87A.5050606@suse.cz \
    --to=mmarek@suse.cz \
    --cc=andi@firstfloor.org \
    --cc=fengguang.wu@intel.com \
    --cc=jmario@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox