From: Gerlando Falauto <gerlando.falauto@keymile.com>
To: Mark Brown <broonie@kernel.org>
Cc: Stephen Warren <swarren@wwwdotorg.org>,
Lars Poeschel <poeschel@lemonage.de>,
Javier Martinez Canillas <javier.martinez@collabora.co.uk>,
Linus Walleij <linus.walleij@linaro.org>,
Lars Poeschel <larsi@wh2.tu-dresden.de>,
Grant Likely <grant.likely@linaro.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ian.campbell@citrix.com>,
Kumar Gala <galak@codeaurora.org>,
Pawel Moll <pawel.moll@arm.com>,
Tomasz Figa <tomasz.figa@gmail.com>,
Enric Balletbo i Serra <eballetbo@gmail.com>,
Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>,
Santosh Shilimkar <santosh.shilimkar@ti.com>,
Kevin Hilman <khilman@linaro.org>, Balaji T K <balajitk@ti.com>,
Tony Lindgren <tony@atomide.com>,
Jon Hunter <jgchunter@gmail.com>
Subject: Re: [PATCH v3] gpio: interrupt consistency check for OF GPIO IRQs
Date: Mon, 11 Nov 2013 19:28:37 +0100 [thread overview]
Message-ID: <528121D5.40403@keymile.com> (raw)
In-Reply-To: <20130909161924.GT29403@sirena.org.uk>
Hi everyone,
[jumping in on an old discussion]
On 09/09/2013 06:19 PM, Mark Brown wrote:
> On Wed, Sep 04, 2013 at 02:16:36PM -0600, Stephen Warren wrote:
>> On 09/04/2013 03:05 AM, Lars Poeschel wrote:
>
>>> The driver that tries to use the GPIO requested by this patch before HAS to
>>> fail. This is exactly the intention of this patch. We don't want the GPIO to
>>> be requested any more, if it is used as an interrupt pin.
>
>> That will break existing drivers. There are drivers that request the
>> same GPIO and IRQ. IIRC, the SDHCI CD (Card Detect) GPIO is requested
>> that way.
>
> Yes, plus input devices and audio jack detection among others. This
> pattern is very common if the GPIO is actually being used as a GPIO, an
> edge triggered interrupt is used to flag when something happens and the
> state is determined by reading the GPIO state (often with some
> debounce).
I actually came across this thread while looking for an answer to the
following (apparently trivial) question:
If you were to write a new driver & binding, what would be, in general,
the recommended DT binding for a cascade interrupt controller (or any
other peripheral, for that matter), which is connected through a GPIO
(to be used as IRQ)?
a) Through gpios = <&gpio0 N>
b) through interrupt-parent = <&gpio0> & interrupts <N
IRQ_TYPE_LEVEL_LOW>, or
c) both?
Thanks!
Gerlando
next prev parent reply other threads:[~2013-11-11 18:29 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-26 14:07 [PATCH v3] gpio: interrupt consistency check for OF GPIO IRQs Lars Poeschel
2013-08-27 20:17 ` Stephen Warren
2013-08-27 20:38 ` Santosh Shilimkar
2013-08-29 19:26 ` Linus Walleij
2013-08-30 0:24 ` Javier Martinez Canillas
2013-08-30 19:55 ` Stephen Warren
2013-09-02 9:25 ` Lars Poeschel
2013-09-03 17:27 ` Stephen Warren
2013-09-04 9:05 ` Lars Poeschel
2013-09-04 20:16 ` Stephen Warren
2013-09-09 16:19 ` Mark Brown
2013-09-10 8:47 ` Lars Poeschel
2013-09-10 13:56 ` Javier Martinez Canillas
2013-09-10 19:52 ` Stephen Warren
2013-09-10 21:23 ` Javier Martinez Canillas
2013-09-11 5:24 ` Joel Fernandes
2013-09-10 19:53 ` Stephen Warren
2013-09-10 21:37 ` Mark Brown
2013-09-10 22:34 ` Stephen Warren
2013-09-11 0:52 ` Javier Martinez Canillas
2013-09-11 19:43 ` Stephen Warren
2013-09-16 16:03 ` Lars Poeschel
2013-09-16 17:09 ` Stephen Warren
2013-09-22 17:01 ` Javier Martinez Canillas
2013-09-23 20:01 ` Linus Walleij
2013-09-23 20:21 ` Stephen Warren
2013-09-24 8:31 ` Linus Walleij
2013-09-24 16:59 ` Stephen Warren
2013-10-11 8:16 ` Linus Walleij
2013-09-23 19:41 ` Linus Walleij
2013-09-23 19:53 ` Linus Walleij
2013-09-23 20:12 ` Stephen Warren
2013-09-24 8:26 ` Linus Walleij
2013-09-24 16:56 ` Stephen Warren
2013-11-11 18:28 ` Gerlando Falauto [this message]
2013-11-11 18:53 ` Stephen Warren
2013-11-11 19:17 ` Gerlando Falauto
2013-11-11 19:33 ` Stephen Warren
2013-11-11 19:38 ` Tomasz Figa
2013-11-12 10:29 ` Linus Walleij
2013-09-03 12:43 ` Linus Walleij
2013-09-03 17:32 ` Stephen Warren
2013-08-30 19:53 ` Stephen Warren
2013-09-02 9:38 ` Lars Poeschel
2013-09-03 17:29 ` Stephen Warren
2013-09-04 9:21 ` Lars Poeschel
2013-09-04 20:18 ` Stephen Warren
2013-09-03 12:35 ` Linus Walleij
2013-09-03 17:29 ` Stephen Warren
2013-09-04 8:35 ` Lars Poeschel
2013-09-04 20:13 ` Stephen Warren
[not found] ` <CAK7N6vrEXVyLHpY-v+SJ668hC0wvHrWOgtviAQ+w5yis7p_E4Q@mail.gmail.com>
2013-09-03 17:22 ` Stephen Warren
2013-08-29 15:14 ` Strashko, Grygorii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=528121D5.40403@keymile.com \
--to=gerlando.falauto@keymile.com \
--cc=balajitk@ti.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=eballetbo@gmail.com \
--cc=galak@codeaurora.org \
--cc=grant.likely@linaro.org \
--cc=ian.campbell@citrix.com \
--cc=javier.martinez@collabora.co.uk \
--cc=jgchunter@gmail.com \
--cc=khilman@linaro.org \
--cc=larsi@wh2.tu-dresden.de \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=plagnioj@jcrosoft.com \
--cc=poeschel@lemonage.de \
--cc=santosh.shilimkar@ti.com \
--cc=swarren@wwwdotorg.org \
--cc=tomasz.figa@gmail.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox