From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755122Ab3KKS3A (ORCPT ); Mon, 11 Nov 2013 13:29:00 -0500 Received: from mail-de.keymile.com ([195.8.104.250]:59131 "EHLO mail-de.keymile.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754171Ab3KKS2w (ORCPT ); Mon, 11 Nov 2013 13:28:52 -0500 Message-ID: <528121D5.40403@keymile.com> Date: Mon, 11 Nov 2013 19:28:37 +0100 From: Gerlando Falauto User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130917 Thunderbird/17.0.9 MIME-Version: 1.0 To: Mark Brown CC: Stephen Warren , Lars Poeschel , Javier Martinez Canillas , Linus Walleij , Lars Poeschel , Grant Likely , "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , Mark Rutland , Ian Campbell , Kumar Gala , Pawel Moll , Tomasz Figa , Enric Balletbo i Serra , Jean-Christophe PLAGNIOL-VILLARD , Santosh Shilimkar , Kevin Hilman , Balaji T K , Tony Lindgren , Jon Hunter Subject: Re: [PATCH v3] gpio: interrupt consistency check for OF GPIO IRQs References: <1377526030-32024-1-git-send-email-larsi@wh2.tu-dresden.de> <1521079.WSLhhfqBXl@lem-wkst-02> <52261BF0.4090106@wwwdotorg.org> <3144247.j2q6H0KWZx@lem-wkst-02> <52279524.8090006@wwwdotorg.org> <20130909161924.GT29403@sirena.org.uk> In-Reply-To: <20130909161924.GT29403@sirena.org.uk> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi everyone, [jumping in on an old discussion] On 09/09/2013 06:19 PM, Mark Brown wrote: > On Wed, Sep 04, 2013 at 02:16:36PM -0600, Stephen Warren wrote: >> On 09/04/2013 03:05 AM, Lars Poeschel wrote: > >>> The driver that tries to use the GPIO requested by this patch before HAS to >>> fail. This is exactly the intention of this patch. We don't want the GPIO to >>> be requested any more, if it is used as an interrupt pin. > >> That will break existing drivers. There are drivers that request the >> same GPIO and IRQ. IIRC, the SDHCI CD (Card Detect) GPIO is requested >> that way. > > Yes, plus input devices and audio jack detection among others. This > pattern is very common if the GPIO is actually being used as a GPIO, an > edge triggered interrupt is used to flag when something happens and the > state is determined by reading the GPIO state (often with some > debounce). I actually came across this thread while looking for an answer to the following (apparently trivial) question: If you were to write a new driver & binding, what would be, in general, the recommended DT binding for a cascade interrupt controller (or any other peripheral, for that matter), which is connected through a GPIO (to be used as IRQ)? a) Through gpios = <&gpio0 N> b) through interrupt-parent = <&gpio0> & interrupts , or c) both? Thanks! Gerlando