From: David Ahern <dsahern@gmail.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
linux-kernel@vger.kernel.org, jolsa@redhat.com,
Frederic Weisbecker <fweisbec@gmail.com>,
Peter Zijlstra <peterz@infradead.org>,
Namhyung Kim <namhyung@kernel.org>,
Mike Galbraith <efault@gmx.de>,
Stephane Eranian <eranian@google.com>
Subject: Re: [PATCH 2/2] perf record: mmap output file - v4
Date: Mon, 11 Nov 2013 13:44:20 -0700 [thread overview]
Message-ID: <528141A4.3050304@gmail.com> (raw)
In-Reply-To: <20131111204104.GB18886@gmail.com>
On 11/11/13, 1:41 PM, Ingo Molnar wrote:
>
> * David Ahern <dsahern@gmail.com> wrote:
>
>> On 11/11/13, 7:58 AM, Arnaldo Carvalho de Melo wrote:
>>>
>>>> Looks very clean now!
>>>
>>>> Acked-by: Ingo Molnar <mingo@kernel.org>
>>>
>>> Applied the prep patch, but waiting for v5 as stated by David when
>>> answering Jiri's concerns.
>>
>> I'll re-send - giving some time for comments on the use of
>> setjmp/longjmp to bounce out of memcpy and error exit when filesystem
>> runs out of space.
>
> Maybe that could be an add-on patch instead?
That's what Arnaldo and I were thinking.
>
> All the rest would already be an improvement, right?
Yes. The longjmp handles the out-of-space failure condition trying to
write the data to a file. With mmap writes you get a SIGBUS when the
filesystem is full and you need to bail out of the memcpy.
David
prev parent reply other threads:[~2013-11-11 20:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-08 4:23 [PATCH 0/2] perf: mmap output file - v4 David Ahern
2013-11-08 4:23 ` [PATCH 1/2] perf record: Move existing write_output into helper function David Ahern
2013-11-12 21:55 ` [tip:perf/urgent] " tip-bot for David Ahern
2013-11-08 4:23 ` [PATCH 2/2] perf record: mmap output file - v4 David Ahern
2013-11-08 9:34 ` Jiri Olsa
2013-11-08 16:52 ` David Ahern
2013-11-11 11:29 ` Ingo Molnar
2013-11-11 14:58 ` Arnaldo Carvalho de Melo
2013-11-11 15:17 ` David Ahern
2013-11-11 20:41 ` Ingo Molnar
2013-11-11 20:44 ` David Ahern [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=528141A4.3050304@gmail.com \
--to=dsahern@gmail.com \
--cc=acme@ghostprotocols.net \
--cc=efault@gmx.de \
--cc=eranian@google.com \
--cc=fweisbec@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).