From: Emmanuel Grumbach <egrumbach@gmail.com>
To: Michal Nazarewicz <mina86@mina86.com>,
Johannes Berg <johannes@sipsolutions.net>
Cc: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
Emmanuel Grumbach <emmanuel.grumbach@intel.com>,
"John W. Linville" <linville@tuxdriver.com>,
Intel Linux Wireless <ilw@linux.intel.com>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCHv2.1] net: wireless: iwlwifi: remove minor dead code
Date: Tue, 12 Nov 2013 07:24:04 +0200 [thread overview]
Message-ID: <5281BB74.50903@gmail.com> (raw)
In-Reply-To: <xa1tr4amwkrt.fsf@mina86.com>
On 11/12/2013 02:01 AM, Michal Nazarewicz wrote:
> inta is checked to be zero in a IRQ_NONE branch so afterwards it
> cannot be zero as it is never modified.
>
> Signed-off-by: Michal Nazarewicz <mina86@mina86.com>
> ---
> drivers/net/wireless/iwlwifi/pcie/rx.c | 24 +++++++++---------------
> 1 file changed, 9 insertions(+), 15 deletions(-)
>
> On Mon, Nov 11 2013, Johannes Berg wrote:
>> no signed-off-by
>
> Sorry, fixed. Interestingly, I did not forget about it in my first patch.
>
no worries - I picked it up in our internal tree.
Thanks!
prev parent reply other threads:[~2013-11-12 5:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-10 19:06 [PATCH] net: wireless: iwlwifi: remove minor dead code Michal Nazarewicz
2013-11-10 19:15 ` Sergei Shtylyov
2013-11-10 20:17 ` [PATCHv2] " Michal Nazarewicz
2013-11-11 13:41 ` Johannes Berg
2013-11-11 13:42 ` Johannes Berg
2013-11-12 0:01 ` [PATCHv2.1] " Michal Nazarewicz
2013-11-12 5:24 ` Emmanuel Grumbach [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5281BB74.50903@gmail.com \
--to=egrumbach@gmail.com \
--cc=emmanuel.grumbach@intel.com \
--cc=ilw@linux.intel.com \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mina86@mina86.com \
--cc=netdev@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).