From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753751Ab3KLRxx (ORCPT ); Tue, 12 Nov 2013 12:53:53 -0500 Received: from mail-wi0-f173.google.com ([209.85.212.173]:40674 "EHLO mail-wi0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752466Ab3KLRxu (ORCPT ); Tue, 12 Nov 2013 12:53:50 -0500 Message-ID: <52826B28.2050208@gmail.com> Date: Tue, 12 Nov 2013 18:53:44 +0100 From: Juri Lelli User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 MIME-Version: 1.0 To: Steven Rostedt CC: peterz@infradead.org, tglx@linutronix.de, mingo@redhat.com, oleg@redhat.com, fweisbec@gmail.com, darren@dvhart.com, johan.eker@ericsson.com, p.faure@akatech.ch, linux-kernel@vger.kernel.org, claudio@evidence.eu.com, michael@amarulasolutions.com, fchecconi@gmail.com, tommaso.cucinotta@sssup.it, nicola.manica@disi.unitn.it, luca.abeni@unitn.it, dhaval.giani@gmail.com, hgu1972@gmail.com, paulmck@linux.vnet.ibm.com, raistlin@linux.it, insop.song@gmail.com, liming.wang@windriver.com, jkacur@redhat.com, harald.gustafsson@ericsson.com, vincent.guittot@linaro.org, bruce.ashfield@windriver.com Subject: Re: [PATCH 01/14] sched: add sched_class->task_dead. References: <1383831828-15501-1-git-send-email-juri.lelli@gmail.com> <1383831828-15501-2-git-send-email-juri.lelli@gmail.com> <20131112121900.6dcfcb0a@gandalf.local.home> In-Reply-To: <20131112121900.6dcfcb0a@gandalf.local.home> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/12/2013 06:19 PM, Steven Rostedt wrote: > On Thu, 7 Nov 2013 14:43:35 +0100 > Juri Lelli wrote: > >> From: Dario Faggioli >> >> Add a new function to the scheduling class interface. It is called >> at the end of a context switch, if the prev task is in TASK_DEAD state. >> >> It might be useful for the scheduling classes that want to be notified >> when one of their task dies, e.g. to perform some cleanup actions. > > Nit. s/task/tasks/ > Amended, thanks! Best, - Juri >> >> Signed-off-by: Dario Faggioli >> Signed-off-by: Juri Lelli >> --- >> kernel/sched/core.c | 3 +++ >> kernel/sched/sched.h | 1 + >> 2 files changed, 4 insertions(+) >> >> diff --git a/kernel/sched/core.c b/kernel/sched/core.c >> index 5ac63c9..850a02c 100644 >> --- a/kernel/sched/core.c >> +++ b/kernel/sched/core.c >> @@ -1890,6 +1890,9 @@ static void finish_task_switch(struct rq *rq, struct task_struct *prev) >> if (mm) >> mmdrop(mm); >> if (unlikely(prev_state == TASK_DEAD)) { >> + if (prev->sched_class->task_dead) >> + prev->sched_class->task_dead(prev); >> + >> /* >> * Remove function-return probe instances associated with this >> * task and put them back on the free list. >> diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h >> index b3c5653..64eda5c 100644 >> --- a/kernel/sched/sched.h >> +++ b/kernel/sched/sched.h >> @@ -992,6 +992,7 @@ struct sched_class { >> void (*set_curr_task) (struct rq *rq); >> void (*task_tick) (struct rq *rq, struct task_struct *p, int queued); >> void (*task_fork) (struct task_struct *p); >> + void (*task_dead) (struct task_struct *p); >> >> void (*switched_from) (struct rq *this_rq, struct task_struct *task); >> void (*switched_to) (struct rq *this_rq, struct task_struct *task); >