From: Shuah Khan <shuah.kh@samsung.com>
To: Alexander Duyck <alexander.h.duyck@intel.com>
Cc: akpm@linux-foundation.org, joro@8bytes.org,
linux-kernel@vger.kernel.org, shuahkhan@gmail.com,
Shuah Khan <shuah.kh@samsung.com>
Subject: Re: [PATCH] dma-debug: enhance dma_debug_device_change() to check for mapping errors
Date: Tue, 12 Nov 2013 15:20:56 -0700 [thread overview]
Message-ID: <5282A9C8.9050304@samsung.com> (raw)
In-Reply-To: <5282A7D5.7050406@intel.com>
On 11/12/2013 03:12 PM, Alexander Duyck wrote:
> I think this might be overdoing the error checking by a bit. I would
> much rather have the DMA leaked error be visible than have it buried
> under messages about the failure to check for DMA errors. In my mind
> the DMA buffer leak is much more serious than the failure to check for
> mapping errors.
>
I agree DMA leak message is more important. Would you like to see just
one message if mapping errors are found? Instead of printing the entire
stacktrace like it does now, it could just do warn.
-- Shuah
--
Shuah Khan
Senior Linux Kernel Developer - Open Source Group
Samsung Research America(Silicon Valley)
shuah.kh@samsung.com | (970) 672-0658
next prev parent reply other threads:[~2013-11-12 22:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-12 20:51 [PATCH] dma-debug: enhance dma_debug_device_change() to check for mapping errors Shuah Khan
2013-11-12 22:12 ` Alexander Duyck
2013-11-12 22:20 ` Shuah Khan [this message]
2013-11-13 0:22 ` Alexander Duyck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5282A9C8.9050304@samsung.com \
--to=shuah.kh@samsung.com \
--cc=akpm@linux-foundation.org \
--cc=alexander.h.duyck@intel.com \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shuahkhan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox