linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: John Stultz <john.stultz@linaro.org>
To: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Cc: Fengguang Wu <fengguang.wu@intel.com>,
	Huang Ying <ying.huang@intel.com>,
	linux-kernel@vger.kernel.org, Ingo Molnar <mingo@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>
Subject: Re: performance regressions by "seqcount: Add lockdep functionality to seqcount/seqlock structures"
Date: Wed, 13 Nov 2013 09:40:48 -0800	[thread overview]
Message-ID: <5283B9A0.2080502@linaro.org> (raw)
In-Reply-To: <20131113091408.GH22256@yliu-dev.sh.intel.com>

On 11/13/2013 01:14 AM, Yuanhan Liu wrote:
> Hi,
>
> FYI, we found some performance regressions caused by commit 1ca7d67c
> ("seqcount: Add lockdep functionality to seqcount/seqlock structures")

So this is expected. seqlock readers are usually very very cheap
operations, and we're now doing lockdep tracking on every iteration
around the loop. As the lockdep help states:

  | If you say Y here, the lock dependency engine will
do                   |  
  | additional runtime checks to debug itself, at the
price                 |  
  | of more runtime overhead.


So now since we're also tracking seqlocks in addition to spinlocks, it
creates more overhead.


Disabling CONFIG_LOCKDEP should restore performance.

thanks
-john


  reply	other threads:[~2013-11-13 17:41 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-13  9:14 performance regressions by "seqcount: Add lockdep functionality to seqcount/seqlock structures" Yuanhan Liu
2013-11-13 17:40 ` John Stultz [this message]
2013-11-14  1:16   ` Yuanhan Liu
2013-11-15 19:24 ` Paul E. McKenney
2013-11-20  9:57   ` Yuanhan Liu
2013-11-20 12:48     ` Paul E. McKenney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5283B9A0.2080502@linaro.org \
    --to=john.stultz@linaro.org \
    --cc=fengguang.wu@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=ying.huang@intel.com \
    --cc=yuanhan.liu@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).