From: Daniel Borkmann <dborkman@redhat.com>
To: Chang <changxiangzhong@gmail.com>
Cc: Vlad Yasevich <vyasevich@gmail.com>,
nhorman@tuxdriver.com, davem@davemloft.net,
linux-sctp@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, dreibh@simula.no
Subject: Re: [PATCH 1/1] net: sctp: bug fixing when sctp path recovers
Date: Wed, 13 Nov 2013 20:10:59 +0100 [thread overview]
Message-ID: <5283CEC3.4050507@redhat.com> (raw)
In-Reply-To: <5283CDD1.3090309@gmail.com>
On 11/13/2013 08:06 PM, Chang wrote:
> On 11/13/2013 09:44 AM, Daniel Borkmann wrote:
>> On 11/13/2013 03:54 AM, Chang wrote:
>>> On 11/13/2013 03:37 AM, Vlad Yasevich wrote:
>>>> On 11/12/2013 08:34 PM, Chang Xiangzhong wrote:
>>>>> Look for the __two__ most recently used path/transport and set to active_path
>>>>> and retran_path respectively
>>
>> Please also for the log, elaborate a bit more, explaining what currently
>> happens, and what the effects of this bug are, so that later when people
>> are looking through the Git log they can easily get what problem you are
>> trying to fix; and if possible, add:
>>
>> Fixes: <12 digits SHA1> ("<commit title>")
>>
> Yeah, sure, I'll elaborate that more specifically.
Thanks !
> I assume the 12-digit SHA1 is the revision number. But may I ask where and how shall I add the tag "Fixes" tag? The revision number is generated after "git commit", how can I know that in advance?
Nope, it's the affected commit id from the current git log that
your patch fixes.
Have a look for example at commit:
98bbc06aabac5a2 ("net: x86: bpf: don't forget to free sk_filter (v2)")
next prev parent reply other threads:[~2013-11-13 19:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-13 1:34 [PATCH 1/1] net: sctp: bug fixing when sctp path recovers Chang Xiangzhong
2013-11-13 2:37 ` Vlad Yasevich
2013-11-13 2:54 ` Chang
2013-11-13 8:44 ` Daniel Borkmann
2013-11-13 19:06 ` Chang
2013-11-13 19:10 ` Daniel Borkmann [this message]
2013-11-13 20:48 ` Chang
2013-11-13 21:23 ` Chang
2013-11-13 21:31 ` Daniel Borkmann
2013-11-13 21:39 ` Vlad Yasevich
2013-11-13 14:22 ` Vlad Yasevich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5283CEC3.4050507@redhat.com \
--to=dborkman@redhat.com \
--cc=changxiangzhong@gmail.com \
--cc=davem@davemloft.net \
--cc=dreibh@simula.no \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sctp@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=vyasevich@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).