From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752318Ab3KNA1d (ORCPT <rfc822;w@1wt.eu>);
	Wed, 13 Nov 2013 19:27:33 -0500
Received: from cn.fujitsu.com ([222.73.24.84]:60258 "EHLO song.cn.fujitsu.com"
	rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP
	id S1751894Ab3KNA1D (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 13 Nov 2013 19:27:03 -0500
X-IronPort-AV: E=Sophos;i="4.93,695,1378828800"; 
   d="scan'208";a="9028698"
Message-ID: <528418B1.6090507@cn.fujitsu.com>
Date: Thu, 14 Nov 2013 08:26:25 +0800
From: Wanlong Gao <gaowanlong@cn.fujitsu.com>
Reply-To: gaowanlong@cn.fujitsu.com
Organization: Fujitsu
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0
MIME-Version: 1.0
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
        linux-sh@vger.kernel.org, lethal@linux-sh.org
CC: linux-kernel@vger.kernel.org, fengguang.wu@intel.com, kbuild-all@01.org,
        Wanlong Gao <gaowanlong@cn.fujitsu.com>
Subject: Re: [PATCH] sh: fix kernel build error
References: <1384353504-21886-1-git-send-email-gaowanlong@cn.fujitsu.com> <5283C19D.4050601@cogentembedded.com>
In-Reply-To: <5283C19D.4050601@cogentembedded.com>
X-MIMETrack: Itemize by SMTP Server on mailserver/fnst(Release 8.5.3|September 15, 2011) at
 2013/11/14 08:25:13,
	Serialize by Router on mailserver/fnst(Release 8.5.3|September 15, 2011) at
 2013/11/14 08:25:14,
	Serialize complete at 2013/11/14 08:25:14
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=ISO-8859-1
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 11/14/2013 02:14 AM, Sergei Shtylyov wrote:
> Hello.
> 
> On 11/13/2013 05:38 PM, Wanlong Gao wrote:
> 
>>     arch/sh/kernel/kgdb.c: In function 'sleeping_thread_to_gdb_regs':
>>>> arch/sh/kernel/kgdb.c:225:32: error: implicit declaration of function 'task_stack_page' [-Werror=implicit-function-declaration]
>>>> arch/sh/kernel/kgdb.c:242:23: error: dereferencing pointer to incomplete type
>>>> arch/sh/kernel/kgdb.c:243:22: error: dereferencing pointer to incomplete type
>>     arch/sh/kernel/kgdb.c: In function 'singlestep_trap_handler':
>>>> arch/sh/kernel/kgdb.c:310:27: error: 'SIGTRAP' undeclared (first use in this function)
>>     arch/sh/kernel/kgdb.c:310:27: note: each undeclared identifier is reported only once for each function it appears in
>>     cc1: all warnings being treated as errors
> 
>    Strange quoting...

Strange? It's the build error log.

> 
>> This is introduced by commit 16559ae.
> 
>    Please also specify that commit's summary line in parens.

commit 16559ae48c76f1ceb970b9719dea62b77eb5d06b
Author: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date:   Mon Feb 4 15:35:26 2013 -0800

    kgdb: remove #include <linux/serial_8250.h> from kgdb.h
    
    There's no reason kgdb.h itself needs to include the 8250 serial port
    header file.  So push it down to the _very_ limited number of individual
    drivers that need the values in that file, and fix up the places where
    people really wanted serial_core.h and platform_device.h.
    
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>


And the line caused this build error is:

diff --git a/include/linux/kgdb.h b/include/linux/kgdb.h
index 4dff0c6..c6e091b 100644
--- a/include/linux/kgdb.h
+++ b/include/linux/kgdb.h
@@ -13,7 +13,6 @@
 #ifndef _KGDB_H_
 #define _KGDB_H_
 
-#include <linux/serial_8250.h>
 #include <linux/linkage.h>
 #include <linux/init.h>
 #include <linux/atomic.h>


Thanks,
Wanlong Gao

> 
>> CC: kbuild-all@01.org
>> Reported-by: Fengguang Wu <fengguang.wu@intel.com>
>> Signed-off-by: Wanlong Gao <gaowanlong@cn.fujitsu.com>
> 
> WBR, Sergei
> 
>