Re: [PATCH 5/7] extcon: arizona: Add support for headphone detection on wm5110 rev D

[Chanwoo Choi <cw00.choi@samsung.com>]

Hi Charles,

On 11/14/2013 03:04 AM, Charles Keepax wrote:
> wm5110 rev D is the first chip to use headphone detection IP 2, specify
> such and make a small correction as the impedance value is actually read
> in 0.5 ohm increments now.
> 
> Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
> ---
>  drivers/extcon/extcon-arizona.c |   11 +++++++++++
>  1 files changed, 11 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/extcon/extcon-arizona.c b/drivers/extcon/extcon-arizona.c
> index e311c52..d08e342 100644
> --- a/drivers/extcon/extcon-arizona.c
> +++ b/drivers/extcon/extcon-arizona.c
> @@ -435,6 +435,7 @@ static int arizona_hpdet_read(struct arizona_extcon_info *info)
>  		}
>  
>  		val &= ARIZONA_HP_LVL_B_MASK;
> +		val /= 2;

What is meaning of 2?

>  
>  		regmap_read(arizona->regmap, ARIZONA_HEADPHONE_DETECT_1,
>  			    &range);
> @@ -1149,6 +1150,16 @@ static int arizona_extcon_probe(struct platform_device *pdev)
>  			break;
>  		}
>  		break;
> +	case WM5110:
> +		switch (arizona->rev) {
> +		case 0 ... 2:
> +			break;
> +		default:
> +			info->micd_clamp = true;
> +			info->hpdet_ip = 2;
> +			break;
> +		}
> +		break;
>  	default:
>  		break;
>  	}
>