public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drivers: scsi: lpfc_debugfs: Fix wrong assignment
@ 2013-10-18 23:15 Felipe Pena
  2013-11-14 15:41 ` James Smart
  0 siblings, 1 reply; 2+ messages in thread
From: Felipe Pena @ 2013-10-18 23:15 UTC (permalink / raw)
  To: James Smart, James E.J. Bottomley; +Cc: linux-scsi, linux-kernel, Felipe Pena

On lpfc_debugfs_initialize function the dumpHostSlim member setup happens
when 'phba->sli_rev < LPFC_SLI_REV4' is true, however when it is false NULL
has been assigned to debug_dumpHBASlim instead of debug_dumpHostSlim.

Signed-off-by: Felipe Pena <felipensp@gmail.com>
---
 drivers/scsi/lpfc/lpfc_debugfs.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/lpfc/lpfc_debugfs.c b/drivers/scsi/lpfc/lpfc_debugfs.c
index 60084e6..b800cc9 100644
--- a/drivers/scsi/lpfc/lpfc_debugfs.c
+++ b/drivers/scsi/lpfc/lpfc_debugfs.c
@@ -4001,7 +4001,7 @@ lpfc_debugfs_initialize(struct lpfc_vport *vport)
 				goto debug_failed;
 			}
 		} else
-			phba->debug_dumpHBASlim = NULL;
+			phba->debug_dumpHostSlim = NULL;

 		/* Setup dumpData */
 		snprintf(name, sizeof(name), "dumpData");
--
1.7.10.4


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] drivers: scsi: lpfc_debugfs: Fix wrong assignment
  2013-10-18 23:15 [PATCH] drivers: scsi: lpfc_debugfs: Fix wrong assignment Felipe Pena
@ 2013-11-14 15:41 ` James Smart
  0 siblings, 0 replies; 2+ messages in thread
From: James Smart @ 2013-11-14 15:41 UTC (permalink / raw)
  To: Felipe Pena; +Cc: James E.J. Bottomley, linux-scsi, linux-kernel

Thanks!

Acked-by:   James Smart  <james.smart@emulex.com>

-- james s


On 10/18/2013 7:15 PM, Felipe Pena wrote:
> On lpfc_debugfs_initialize function the dumpHostSlim member setup happens
> when 'phba->sli_rev < LPFC_SLI_REV4' is true, however when it is false NULL
> has been assigned to debug_dumpHBASlim instead of debug_dumpHostSlim.
>
> Signed-off-by: Felipe Pena <felipensp@gmail.com>
> ---
>   drivers/scsi/lpfc/lpfc_debugfs.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/lpfc/lpfc_debugfs.c b/drivers/scsi/lpfc/lpfc_debugfs.c
> index 60084e6..b800cc9 100644
> --- a/drivers/scsi/lpfc/lpfc_debugfs.c
> +++ b/drivers/scsi/lpfc/lpfc_debugfs.c
> @@ -4001,7 +4001,7 @@ lpfc_debugfs_initialize(struct lpfc_vport *vport)
>   				goto debug_failed;
>   			}
>   		} else
> -			phba->debug_dumpHBASlim = NULL;
> +			phba->debug_dumpHostSlim = NULL;
>
>   		/* Setup dumpData */
>   		snprintf(name, sizeof(name), "dumpData");
> --
> 1.7.10.4
>
>
>


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-11-14 15:41 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-18 23:15 [PATCH] drivers: scsi: lpfc_debugfs: Fix wrong assignment Felipe Pena
2013-11-14 15:41 ` James Smart

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox