From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752225AbbJLPWT (ORCPT <rfc822;w@1wt.eu>);
	Mon, 12 Oct 2015 11:22:19 -0400
Received: from mout.kundenserver.de ([212.227.17.24]:49267 "EHLO
	mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751580AbbJLPWR (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 12 Oct 2015 11:22:17 -0400
From: Arnd Bergmann <arnd@arndb.de>
To: John Garry <john.garry@huawei.com>
Cc: James.Bottomley@hansenpartnership.com, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org, linuxarm@huawei.com,
        zhangfei.gao@linaro.org, linux-scsi@vger.kernel.org,
        xuwei5@hisilicon.com, john.garry2@mail.dcu.ie, hare@suse.de
Subject: Re: [PATCH 07/25] scsi: hisi_sas: add ioremap for device HW
Date: Mon, 12 Oct 2015 17:21:53 +0200
Message-ID: <5285087.C8umupFr76@wuerfel>
User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; )
In-Reply-To: <1444663237-238302-8-git-send-email-john.garry@huawei.com>
References: <1444663237-238302-1-git-send-email-john.garry@huawei.com> <1444663237-238302-8-git-send-email-john.garry@huawei.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:7O8A61fLmXWCL3/2c2sgSQIOBQORuu8cvvMfQRaRCFFb24AR57X
 E2OU5D4tp+XyvLpoLDGPiJyywYmPojrwLqQlhB7Ixq0QgAd3FWOWpSTkzNr+tu/VxnRAH0K
 KDBXSwhVPHGWuSIBRM8AODUW5RDhuj8PDLEtbhp5/tLkaEmNUc4wiuHtlr1/HcNm5/cMnLr
 Wj3CVyolvdgB9OvHJGL/w==
X-UI-Out-Filterresults: notjunk:1;V01:K0:f1JTf2Ed4Ro=:pFduIm0sro4q1v09Pvaujk
 uRXyct0QwvVGBsftilyA1EDkiGia6voTt8HYWte3YxE8dlpBarpNE8BFw4Ee/+6yYrIOITNmq
 V1KF5tNoYzE2VQQiTErn5vlsgkxzr4yMStb6MH4fcRNsTMiTOFXUS2xCgBlCE3UYmQRxTSbEh
 +yKrfoxlyf9WxFD9ZBkaLSivyWSJMpowQhTtszXYyQpLbNbNWscoy1CKCLF9yZHLwoKQmaLFo
 YUkUmGMplzkba4KVZtcLL5+ItRcxQI+lg0QRXOdVT6zSK+Hb7G7/UAFl9NndJE80bTkLi7EAU
 AaGfJwxT+oxrGsE8JSfOPheRPnPyohC7HkwRxyRwgA3Z31YCX/JOm8s+YqzsrCpfTHjNDm+6n
 FUj6lX8TtwVD/pzTkSbAL3nUY+fXH2Z7OR5jEbQ8jFS/ULKQTJk5Jj4MaJsVxr47DIKbxThsu
 70Zvb4ci/oaXddyJ+/1aLtzWHNT8b4q+WJWf2H1Mj+IFKqt2uhtrNhKCwDINMeCzFsLqU3ERn
 v8PBX9lgBhSb+KN7rrq2YTbjvJfTvxVTA6Z55LFkwFl91vFiFxu7qVK5Utg8iULcrYfNjH2de
 7HAt0DMVwldzDopCOZO40CFJSzJRn719TArY9Twfc8lqKED0Cyqz96iurArI0KJjKwkDPbOUH
 l39zb3lDmJt2m1Nj4pHXK2YFqr6ppe0hW1OQSWEtBFw0vR++KdqfFrowO6N4Jdcyhm4JB0imb
 zkSDLxxw1WL3dQgu
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Monday 12 October 2015 23:20:19 John Garry wrote:
> +int hisi_sas_ioremap(struct hisi_hba *hisi_hba)
> +{
> +       struct platform_device *pdev = hisi_hba->pdev;
> +       struct device *dev = &pdev->dev;
> +       struct resource *res;
> +
> +       res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> +       hisi_hba->regs = devm_ioremap(dev,
> +                                     res->start,
> +                                     resource_size(res));
> +       if (!hisi_hba->regs)
> +               return -ENOMEM;
> +
> +       res = platform_get_resource(pdev, IORESOURCE_MEM, 1);
> +       hisi_hba->ctrl_regs = devm_ioremap(dev,
> +                                          res->start,
> +                                          resource_size(res));
> +       if (!hisi_hba->ctrl_regs)
> +               return -ENOMEM;
> +
> +       return 0;
> +}
>  
>  static const struct of_device_id sas_of_match[] = {
> 

Better use devm_ioremap_resource() here, which registers the resource so they
are checked for conflicts and listed in /proc/iomem.

	Arnd