Re: [PATCH v2] panic: setup panic_timeout early

[Levente Kurusa <levex@linux.com>]

2013-11-14 12:16 keltezéssel, Felipe Contreras írta:
> On Tue, Nov 12, 2013 at 6:03 PM, Ingo Molnar <mingo@kernel.org> wrote:
>>
>> * Felipe Contreras <felipe.contreras@gmail.com> wrote:
>>
>>> Otherwise we might not reboot when the user needs it the most (early
>>> on).
>>>
>>> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
>>> ---
>>>
>> [...]
>>>
>>> diff --git a/kernel/panic.c b/kernel/panic.c
>>> index b6c482c..d865263 100644
>>> --- a/kernel/panic.c
>>> +++ b/kernel/panic.c
>>> @@ -468,9 +468,23 @@ EXPORT_SYMBOL(__stack_chk_fail);
>>>
>>>  #endif
>>>
>>> -core_param(panic, panic_timeout, int, 0644);
>>>  core_param(pause_on_oops, pause_on_oops, int, 0644);
>>>
>>> +static int __init set_panic_timeout(char *val)
>>> +{
>>> +     long timeout;
>>> +     int ret;
>>> +
>>> +     ret = kstrtol(val, 0, &timeout);
>>> +     if (ret < 0)
>>> +             return ret;
>>> +
>>> +     panic_timeout = timeout;
>>> +     return 0;
>>> +}
>>
>> I think the type of the 'timeout' local variable should match the type of
>> 'panic_timeout' (which is 'int', not 'long').
> 
> So you would rather have this?
> 
>   kstrtol(val, 0, (long *)&timeout);
> 
> Couldn't that potentially write the value beyond the memory allocated
> to 'timeout'?
> 

No, 'panic_timeout' is a variable of type 'int'.
Your 'long timeout;' line is wrong and should say 'int timeout;'


-- 
Regards,
Levente Kurusa