public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: David Ahern <dsahern@gmail.com>
To: Pekka Enberg <penberg@kernel.org>,
	linux-kernel@vger.kernel.org,
	Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Subject: Re: [PATCH] perf trace: Remove thread summary coloring
Date: Thu, 14 Nov 2013 13:31:48 -0700	[thread overview]
Message-ID: <52853334.9020304@gmail.com> (raw)
In-Reply-To: <1384447410-1771-1-git-send-email-penberg@kernel.org>

On 11/14/13, 9:43 AM, Pekka Enberg wrote:
> Thread summary line coloring looks ugly.  It doesn't add much value so
> remove coloring completely.
>
> Signed-off-by: Pekka Enberg <penberg@kernel.org>
> ---
>   tools/perf/builtin-trace.c | 13 ++-----------
>   1 file changed, 2 insertions(+), 11 deletions(-)
>

Looks good to me.
Acked-by: David Ahern <dsahern@gmail.com>


  reply	other threads:[~2013-11-14 20:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-14 16:43 [PATCH] perf trace: Remove thread summary coloring Pekka Enberg
2013-11-14 20:31 ` David Ahern [this message]
2013-11-14 20:37   ` Arnaldo Carvalho de Melo
2013-11-30 12:49 ` [tip:perf/core] " tip-bot for Pekka Enberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52853334.9020304@gmail.com \
    --to=dsahern@gmail.com \
    --cc=acme@ghostprotocols.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=penberg@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox