From: David Cohen <david.a.cohen@linux.intel.com>
To: One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>
Cc: matthew.garrett@nebula.com, platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org, eric.ernst@linux.intel.com,
Kuppuswamy Sathyanarayanan
<sathyanarayanan.kuppuswamy@linux.intel.com>
Subject: Re: [PATCH 3/3] ipc: Added support for IPC interrupt mode
Date: Thu, 14 Nov 2013 13:31:56 -0800 [thread overview]
Message-ID: <5285414C.809@linux.intel.com> (raw)
In-Reply-To: <20131114210015.25dab122@alan.etchedpixels.co.uk>
On 11/14/2013 01:00 PM, One Thousand Gnomes wrote:
> On Thu, 14 Nov 2013 09:36:18 -0800
> David Cohen <david.a.cohen@linux.intel.com> wrote:
>
>> Hi Alan,
>>
>> [snip]
>>
>>> So I think
>>>
>>> 1. Pass the informatio upon whether IRQ mode should be used in the
>>> platform information and remove all the ifdeffery
>>
>> I will double check with Sathya. But in case polling mode is left for
>> development purpose, make we can create a static variable to set irq
>> mode or not.
>
> If its only for development it doesn't IMHO need to be upstream. If its
> useful for debug and/or needed on real chipsets (as I believe is the case
> for the older ones) then a module (and thus kernel command line) option
> would be sensible yes.
Looks like this patch is keeping poll mode for Lincroft support, since
interrupt mode was never tested there. We're sending new version of
this patch set soon.
Br, David
next prev parent reply other threads:[~2013-11-14 21:27 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-13 20:14 [PATCH 0/3] Enable more Intel Mid platforms on IPC driver David Cohen
2013-11-13 20:14 ` [PATCH 1/3] ipc: Added platform data structure David Cohen
2013-11-14 13:42 ` One Thousand Gnomes
2013-11-13 20:14 ` [PATCH 2/3] ipc: Enabled ipc support for additional intel platforms David Cohen
2013-11-14 13:43 ` One Thousand Gnomes
2013-11-14 17:31 ` David Cohen
2013-11-14 21:01 ` One Thousand Gnomes
2013-11-13 20:14 ` [PATCH 3/3] ipc: Added support for IPC interrupt mode David Cohen
2013-11-14 13:48 ` One Thousand Gnomes
2013-11-14 17:36 ` David Cohen
2013-11-14 21:00 ` One Thousand Gnomes
2013-11-14 21:31 ` David Cohen [this message]
2013-11-14 22:15 ` [PATCH v2 0/4] Enable more Intel Mid platforms on IPC driver David Cohen
2013-11-14 22:15 ` [PATCH v2 1/4] ipc: Added platform data structure David Cohen
2013-11-14 22:15 ` [PATCH v2 2/4] ipc: Enabled ipc support for additional intel platforms David Cohen
2013-11-14 22:15 ` [PATCH v2 3/4] ipc: Handle error conditions in ipc command David Cohen
2013-11-14 22:15 ` [PATCH v2 4/4] ipc: Added support for IPC interrupt mode David Cohen
2013-11-16 0:21 ` [PATCH v2.1] " David Cohen
2013-11-21 1:45 ` [PATCH v2.2] " Kuppuswamy Sathyanarayanan
2013-11-21 1:47 ` Matthew Garrett
2013-11-21 1:48 ` sathyanarayanan kuppuswamy
2013-11-20 23:51 ` [PATCH v2 0/4] Enable more Intel Mid platforms on IPC driver Matthew Garrett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5285414C.809@linux.intel.com \
--to=david.a.cohen@linux.intel.com \
--cc=eric.ernst@linux.intel.com \
--cc=gnomes@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.garrett@nebula.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).