From: Jeff Liu <jeff.liu@oracle.com>
To: linux-kernel@vger.kernel.org
Cc: akpm@linux-foundation.org, "xfs@oss.sgi.com" <xfs@oss.sgi.com>,
cluster-devel@redhat.com, linux-mtd@lists.infradead.org,
jfs-discussion@lists.sourceforge.net, oleg@redhat.com,
jiri@resnulli.us, gregkh@linuxfoundation.org
Subject: [PATCH 4/6] ubifs: simplify drop_last_node() via list_last_entry_or_null()
Date: Fri, 15 Nov 2013 12:33:56 +0800 [thread overview]
Message-ID: <5285A434.2080608@oracle.com> (raw)
From: Jie Liu <jeff.liu@oracle.com>
Simplify the code in drop_last_node() via list_last_entry_or_null().
Signed-off-by: Jie Liu <jeff.liu@oracle.com>
---
fs/ubifs/recovery.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/fs/ubifs/recovery.c b/fs/ubifs/recovery.c
index 065096e..e46c394 100644
--- a/fs/ubifs/recovery.c
+++ b/fs/ubifs/recovery.c
@@ -603,12 +603,10 @@ static void drop_last_group(struct ubifs_scan_leb *sleb, int *offs)
*/
static void drop_last_node(struct ubifs_scan_leb *sleb, int *offs)
{
- struct ubifs_scan_node *snod;
-
- if (!list_empty(&sleb->nodes)) {
- snod = list_entry(sleb->nodes.prev, struct ubifs_scan_node,
- list);
+ struct ubifs_scan_node *snod = list_last_entry_or_null(&sleb->nodes,
+ struct ubifs_scan_node, list);
+ if (snod) {
dbg_rcvry("dropping last node at %d:%d",
sleb->lnum, snod->offs);
*offs = snod->offs;
--
1.8.3.2
reply other threads:[~2013-11-15 4:34 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5285A434.2080608@oracle.com \
--to=jeff.liu@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=cluster-devel@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=jfs-discussion@lists.sourceforge.net \
--cc=jiri@resnulli.us \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=oleg@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).