Re: [PATCH 3/4] arm64: dts: rockchip: Add HINLINK H68K

From: Erik Beck <xunil@tahomasoft.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Chukun Pan <amadeus@jmu.edu.cn>, Heiko Stuebner <heiko@sntech.de>,
	Rob Herring <robh@kernel.org>, Conor Dooley <conor+dt@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org
Subject: Re: [PATCH 3/4] arm64: dts: rockchip: Add HINLINK H68K
Date: Sat, 30 Aug 2025 18:21:18 -0400	[thread overview]
Message-ID: <5285B176-5178-4F6F-8FB6-B898AC0EC939@tahomasoft.com> (raw)
In-Reply-To: <021c2e76-cbde-4a2e-a165-a61223cdff93@lunn.ch>


> On Aug 30, 2025, at 17:38, Andrew Lunn <andrew@lunn.ch> wrote:
> 
> 
>> 
>>> +&gmac0 {
>>> +    assigned-clocks = <&cru SCLK_GMAC0_RX_TX>, <&cru SCLK_GMAC0>;
>>> +    assigned-clock-parents = <&cru SCLK_GMAC0_RGMII_SPEED>;
>>> +    assigned-clock-rates = <0>, <125000000>;
>>> +    clock_in_out = "output";
>>> +    phy-handle = <&rgmii_phy0>;
>>> +    phy-mode = "rgmii-id";
>> 
>> Please change phy-mode here to "rgmii". This change will yield an ethernet
>> speed throughput change of a factor of 100+.
> 
> Rockchip by default do bad things with RGMII delays.
> 
>  tx_delay:
>    description: Delay value for TXD timing.
>    $ref: /schemas/types.yaml#/definitions/uint32
>    minimum: 0
>    maximum: 0x7F
>    default: 0x30
> 
>  rx_delay:
>    description: Delay value for RXD timing.
>    $ref: /schemas/types.yaml#/definitions/uint32
>    minimum: 0
>    maximum: 0x7F
>    default: 0x10
> 
> Try setting both of these to 0. And then use 'rgmii-id'.
> 
>    Andrew

Thank you!
> 
> _______________________________________________
> Linux-rockchip mailing list
> Linux-rockchip@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-rockchip