Re: [PATCH] regmap: Fix 'ret' would return an uninitialized value

Mark Brown
2013-11-14T12:58:22Z

[-- Attachment #1: Type: text/plain, Size: 430 bytes --]

On Mon, Nov 11, 2013 at 11:35:52AM +0000, Caizhiyong wrote:

> + int ret = 0;

With the if statement below you probably don't need to do this any more.

> + if (num_regs <= 0) {
> + WARN_ONCE(1, "Call regmap_register_patch with num_regs <= 0.");
> + return 0;
> + }

WARN_ONCE actually returns the result of the test so you should be able
to write this as:

if (WARN_ONCE(num_regs <= 0))
return 0;

which is slightly neater.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]