From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751669Ab3KPFY7 (ORCPT ); Sat, 16 Nov 2013 00:24:59 -0500 Received: from mail-qa0-f52.google.com ([209.85.216.52]:39087 "EHLO mail-qa0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750942Ab3KPFYv (ORCPT ); Sat, 16 Nov 2013 00:24:51 -0500 Message-ID: <5287019E.2080608@linaro.org> Date: Sat, 16 Nov 2013 10:54:46 +0530 From: viresh kumar User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 MIME-Version: 1.0 To: Lan Tianyu , rainer.kaluscha@web.de CC: "Rafael J. Wysocki" , "cpufreq@vger.kernel.org" , "linux-pm@vger.kernel.org" , Linux Kernel Mailing List Subject: Re: [Update PATCH 1/1] Cpufreq: Make governor data on nonboot cpus across system suspend/resume References: <1384495294-10565-1-git-send-email-tianyu.lan@intel.com> <1384503334-18809-1-git-send-email-tianyu.lan@intel.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday 15 November 2013 04:24 PM, Viresh Kumar wrote: > Though the patch I have sent fixes a problem similar to this but I don't think > patch of any of us will solve the issue Rainer is facing.. > > I checked his system configuration and its like this: > - Four CPUs, all having separate clock domains (atleast from kernel > perspective) and so separate policy structure. > - All are using ondemand governor > - not using CPUFREQ_HAVE_GOVERNOR_PER_POLICY feature > - So there is a single set of tunables for ondemand governor that is applicable > across all CPUs.. > > The way INIT/EXIT are designed in cpufreq_governor.c should take care > of this scenario. > > memory for tunables must not be freed unless all the CPUs are removed. > Which can't happen, as we only offline non-boot CPUs and so I believe > that memory isn't getting freed and so your solution wouldn't address his > problem.. > > Sorry if I said something stupid enough :) I haven't :) >>From your another mail it is clear that you have used separate governors and so you have faced the real problem :) Hope my patch fixes it for you.