From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751377AbdHFPeY (ORCPT ); Sun, 6 Aug 2017 11:34:24 -0400 Received: from mout.web.de ([212.227.17.11]:49373 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751300AbdHFPeX (ORCPT ); Sun, 6 Aug 2017 11:34:23 -0400 To: kernel-janitors@vger.kernel.org, "Ed L. Cashin" Cc: LKML From: SF Markus Elfring Subject: [PATCH] block-AoE: Delete an error message for a failed memory allocation in aoechr_error() Message-ID: <52881fa9-34ef-5604-795b-1f151b20f80d@users.sourceforge.net> Date: Sun, 6 Aug 2017 17:34:15 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:vC7iKkbDVi/hUgbZ3G91HpjoI3+rBDVfB0Z/p5vUkjwfTCp6MCf jDcSOgNb2smxbe7wKHtOH6MatQzZkg580JqU6eXAD9nqfyQ4MxFJiyhXKWoRQkckQHM3CmY HVuzrVKwC2L56gEY4algNmAVmOgGsK6qcgpmNngGD+QCdN8beUfTuuYwRCCFJAJ6BtkI785 KAl2Jz+XI2EJbp9KohCHg== X-UI-Out-Filterresults: notjunk:1;V01:K0:oxP9CuEM1bs=:K8gZXoV6fmT1fO+olkqaF1 ochlQiCEsDwRRFdxLLdhiSrRZECxrf6jZGUu4xYcSSBKXVzHu0Q3CfnARtb9YO0jwGN2yZnr3 x5knTXJnIHDcWoE7fYMX1rRheduZzCgxSf/fDawPyayl364+UE6eyTHiSlNPTQqQgnpHW0kHz RlJnTf3bejqplCCHFLhylEFnyiQ9nWLJ1uYHpdISbBjTdUz2Qsf56bJKhOG0AyoqhFH7bxjB0 iGFMZnTk3+swCU/aj0rdao+P6ZNHBxxGdAfTwj19OO+VjllWLlU3yNfHZHNqZNTjHscbCQpUw DFVIDSvIfEc30ucwIV1zKrqNaPpTDCfhpjXtHnJ4YNO7WxHGhXCgWi23qW5N+KQuS6qMh2IzE o0nj2RsYqhqOyhTov6V78ncZWHllAnV51CtWH2ptRK+b/ieptMUAXl8ElGyIknPZ1spAua4M4 4eYNkbE1StTgX8ffBSnTEJGWDtKZkEMRg8bf/pfSRitDwKl249Xdwq4AyUn3VSIZwpvabd2mk a7IwbvZl5KY+wumpVrW3Ubz4Gf3l5v7cYccpNNfF0XH2kNehNZS2MbicvRV1B2z+IZftZbU9V NknU1EWkDFmwq8alyvvL4ZwpeouFbQNm7wMqma3IN6w+zi3cUM2QoK3PD5iMBH/m5IIAOhR32 bQZA7wSxbd6+0C8xe/OeA51CFkK39O3SFFAQo4ZHGZ7GxHOsDIGAkWAWq7WAQcb64M76YLaaC E4D+tVVA80CtR1HrbwzAZTKTuO1/f5r5rgHysbHmGx+igAPcmA96KIZInqCtIm5qZt5B3bx5c MbHGPwpLCub5YRiheufM+oVcKDpP367ReCr0uNOZRHsXLTaUic= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Sun, 6 Aug 2017 17:27:18 +0200 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf Signed-off-by: Markus Elfring --- drivers/block/aoe/aoechr.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/block/aoe/aoechr.c b/drivers/block/aoe/aoechr.c index ab41be625a53..8eea2529da20 100644 --- a/drivers/block/aoe/aoechr.c +++ b/drivers/block/aoe/aoechr.c @@ -140,10 +140,8 @@ bail: spin_unlock_irqrestore(&emsgs_lock, flags); } mp = kmemdup(msg, n, GFP_ATOMIC); - if (mp == NULL) { - printk(KERN_ERR "aoe: allocation failure, len=%ld\n", n); + if (!mp) goto bail; - } em->msg = mp; em->flags |= EMFL_VALID; -- 2.13.4