Re: [PATCH V2] Cpufreq: Make governor data on nonboot cpus across system suspend/resume

Viresh Kumar
2013-11-21T15:54:07Z

On 21 November 2013 20:13, Rafael J. Wysocki <rjw@rjwysocki.net> wrote:
>> - if (((event == CPUFREQ_GOV_POLICY_INIT) && ret) ||
>
> The inner parens are not necessary.
>
>> - ((event == CPUFREQ_GOV_POLICY_EXIT) && !ret))
>> + if ((event == CPUFREQ_GOV_POLICY_INIT) && ret) {
>
> Same here.
>
>> + module_put(policy->governor->owner);
>> + if (ret == -EALREADY)
>> + return 0;
>> + } else if ((event == CPUFREQ_GOV_POLICY_EXIT) && !ret) {
>
> Same here.

Logically, yes you are correct. But probably its better for readability to
get these even if you know precedence is going to take care of our
expression..