From: "ivan.khoronzhuk" <ivan.khoronzhuk@ti.com>
To: Guenter Roeck <linux@roeck-us.net>,
Santosh Shilimkar <santosh.shilimkar@ti.com>, <wim@iguana.be>,
<nsekhar@ti.com>, <linux-watchdog@vger.kernel.org>,
<devicetree@vger.kernel.org>
Cc: <grant.likely@linaro.org>, <rob.herring@calxeda.com>,
<pawel.moll@arm.com>, <mark.rutland@arm.com>,
<swarren@wwwdotorg.org>, <galak@kernel.crashing.org>,
<ijc+devicetree@hellion.org.uk>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: Fwd: [PATCH 7/8] watchdog: davinci: add "clocks" property
Date: Mon, 18 Nov 2013 17:26:06 +0200 [thread overview]
Message-ID: <528A318E.1090209@ti.com> (raw)
In-Reply-To: <528829DB.7020003@roeck-us.net>
On 11/17/2013 04:28 AM, Guenter Roeck wrote:
> On 11/06/2013 03:32 AM, ivan.khoronzhuk wrote:
>> The Keystone arch is using clocks in DT and source clock for watchdog
>> has to be specified, so add this to binding.
>>
>> Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@ti.com>
>> ---
>> .../devicetree/bindings/watchdog/davinci-wdt.txt | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git
>> a/Documentation/devicetree/bindings/watchdog/davinci-wdt.txt
>> b/Documentation/devicetree/bindings/watchdog/davinci-wdt.txt
>> index fddced9..4db4d0e 100644
>> --- a/Documentation/devicetree/bindings/watchdog/davinci-wdt.txt
>> +++ b/Documentation/devicetree/bindings/watchdog/davinci-wdt.txt
>> @@ -7,6 +7,10 @@ Required properties:
>>
>> - reg : Should contain WDT registers location and length
>>
>> +- clocks: phandle reference to the controller clock.
>> + Required only for Keystone arch.
>> + See clock-bindings.txt
>> +
>
> Yet another form of formatting. Also, wonder if it makes sense to merge
> this with the patch adding keystone support.
>
Ok, I'll squash them.
>> Optional properties:
>>
>> - timeout-sec: Contains the watchdog timeout in seconds
>> @@ -21,4 +25,5 @@ wdt: wdt@2320000 {
>> compatible = "ti,davinci-wdt";
>> reg = <0x02320000 0x80>;
>> timeout-sec = <30>;
>> + clocks = <&clkwdtimer0>;
>> };
>>
>
--
Regards,
Ivan Khoronzhuk
next prev parent reply other threads:[~2013-11-18 15:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1383680783-12114-8-git-send-email-ivan.khoronzhuk@ti.com>
2013-11-06 11:32 ` Fwd: [PATCH 7/8] watchdog: davinci: add "clocks" property ivan.khoronzhuk
2013-11-12 15:40 ` Santosh Shilimkar
2013-11-17 2:28 ` Guenter Roeck
2013-11-18 15:26 ` ivan.khoronzhuk [this message]
2013-11-23 17:57 ` Arnd Bergmann
2013-11-25 10:59 ` ivan.khoronzhuk
2013-11-25 12:15 ` Mark Rutland
2013-11-25 12:41 ` ivan.khoronzhuk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=528A318E.1090209@ti.com \
--to=ivan.khoronzhuk@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@kernel.crashing.org \
--cc=grant.likely@linaro.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mark.rutland@arm.com \
--cc=nsekhar@ti.com \
--cc=pawel.moll@arm.com \
--cc=rob.herring@calxeda.com \
--cc=santosh.shilimkar@ti.com \
--cc=swarren@wwwdotorg.org \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox