From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751544Ab3KRP1p (ORCPT <rfc822;w@1wt.eu>);
	Mon, 18 Nov 2013 10:27:45 -0500
Received: from bear.ext.ti.com ([192.94.94.41]:33026 "EHLO bear.ext.ti.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751167Ab3KRP1h (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 18 Nov 2013 10:27:37 -0500
Message-ID: <528A318E.1090209@ti.com>
Date: Mon, 18 Nov 2013 17:26:06 +0200
From: "ivan.khoronzhuk" <ivan.khoronzhuk@ti.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0
MIME-Version: 1.0
To: Guenter Roeck <linux@roeck-us.net>,
        Santosh Shilimkar <santosh.shilimkar@ti.com>, <wim@iguana.be>,
        <nsekhar@ti.com>, <linux-watchdog@vger.kernel.org>,
        <devicetree@vger.kernel.org>
CC: <grant.likely@linaro.org>, <rob.herring@calxeda.com>, <pawel.moll@arm.com>,
        <mark.rutland@arm.com>, <swarren@wwwdotorg.org>,
        <galak@kernel.crashing.org>, <ijc+devicetree@hellion.org.uk>,
        <linux-kernel@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>
Subject: Re: Fwd: [PATCH 7/8] watchdog: davinci: add "clocks" property
References: <1383680783-12114-8-git-send-email-ivan.khoronzhuk@ti.com> <527A28E8.4010204@ti.com> <528829DB.7020003@roeck-us.net>
In-Reply-To: <528829DB.7020003@roeck-us.net>
Content-Type: text/plain; charset="ISO-8859-1"; format=flowed
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.167.145.122]
X-EXCLAIMER-MD-CONFIG: f9c360f5-3d1e-4c3c-8703-f45bf52eff6b
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 11/17/2013 04:28 AM, Guenter Roeck wrote:
> On 11/06/2013 03:32 AM, ivan.khoronzhuk wrote:
>> The Keystone arch is using clocks in DT and source clock for watchdog
>> has to be specified, so add this to binding.
>>
>> Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@ti.com>
>> ---
>>   .../devicetree/bindings/watchdog/davinci-wdt.txt   |    5 +++++
>>   1 file changed, 5 insertions(+)
>>
>> diff --git
>> a/Documentation/devicetree/bindings/watchdog/davinci-wdt.txt
>> b/Documentation/devicetree/bindings/watchdog/davinci-wdt.txt
>> index fddced9..4db4d0e 100644
>> --- a/Documentation/devicetree/bindings/watchdog/davinci-wdt.txt
>> +++ b/Documentation/devicetree/bindings/watchdog/davinci-wdt.txt
>> @@ -7,6 +7,10 @@ Required properties:
>>
>>   - reg : Should contain WDT registers location and length
>>
>> +- clocks: phandle reference to the controller clock.
>> +      Required only for Keystone arch.
>> +      See clock-bindings.txt
>> +
>
> Yet another form of formatting. Also, wonder if it makes sense to merge
> this with the patch adding keystone support.
>

Ok, I'll squash them.

>>   Optional properties:
>>
>>   - timeout-sec:        Contains the watchdog timeout in seconds
>> @@ -21,4 +25,5 @@ wdt: wdt@2320000 {
>>       compatible = "ti,davinci-wdt";
>>       reg = <0x02320000 0x80>;
>>       timeout-sec = <30>;
>> +    clocks = <&clkwdtimer0>;
>>   };
>>
>

-- 
Regards,
Ivan Khoronzhuk