From: Florian Meier <florian.meier@koalo.de>
To: "Shevchenko, Andriy" <andriy.shevchenko@intel.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Stephen Warren <swarren@wwwdotorg.org>,
Lars-Peter Clausen <lars@metafoo.de>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
linux-rpi-kernel <linux-rpi-kernel@lists.infradead.org>,
devicetree <devicetree@vger.kernel.org>,
dmaengine <dmaengine@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCHv3] ASoC: Add support for BCM2835
Date: Mon, 18 Nov 2013 16:56:33 +0100 [thread overview]
Message-ID: <528A38B1.5010107@koalo.de> (raw)
In-Reply-To: <1384776479.14845.208.camel@smile>
>> +static int bcm2835_i2s_hw_params(struct snd_pcm_substream *substream,
>> + struct snd_pcm_hw_params *params,
>> + struct snd_soc_dai *dai)
>> +{
>> + struct bcm2835_i2s_dev *dev = snd_soc_dai_get_drvdata(dai);
>> +
>> + unsigned int sampling_rate = params_rate(params);
>> + unsigned int data_length, data_delay, bclk_ratio;
>> + unsigned int ch1pos, ch2pos, mode, format;
>> + unsigned int mash = BCM2835_CLK_MASH_1;
>> + unsigned int divi, divf, target_frequency;
>> + int clk_src = -1;
>> + unsigned int master = dev->fmt & SND_SOC_DAIFMT_MASTER_MASK;
>> + uint32_t bit_master = (master == SND_SOC_DAIFMT_CBS_CFS
>> + || master == SND_SOC_DAIFMT_CBS_CFM);
>> +
>> + uint32_t frame_master = (master == SND_SOC_DAIFMT_CBS_CFS
>
> So, if master == SND_SOC_DAIFMT_CBS_CFS both bit_master and frame_master
> will be true. Is it correct?
Yes. That is exactly what CBS_CFS expresses:
Codec Bit Slave and Codec Frame Slave
So the interface is bit master as well as frame master.
Did I miss anything?
next prev parent reply other threads:[~2013-11-18 15:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-18 11:28 [PATCHv3] ASoC: Add support for BCM2835 Florian Meier
2013-11-18 12:08 ` Shevchenko, Andriy
2013-11-18 15:56 ` Florian Meier [this message]
2013-11-18 14:16 ` Mark Rutland
2013-11-18 14:24 ` Lars-Peter Clausen
2013-11-18 15:06 ` Mark Rutland
2013-11-18 14:25 ` Florian Meier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=528A38B1.5010107@koalo.de \
--to=florian.meier@koalo.de \
--cc=alsa-devel@alsa-project.org \
--cc=andriy.shevchenko@intel.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox