From: David Cohen <david.a.cohen@linux.intel.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: mingo@kernel.org, hpa@zytor.com, tglx@linutronix.de,
x86@kernel.org, linux-kernel@vger.kernel.org, lenb@kernel.org
Subject: Re: [PATCH v1.1] x86: intel-mid: add test module for sfi_device()
Date: Mon, 18 Nov 2013 09:35:41 -0800 [thread overview]
Message-ID: <528A4FED.3030709@linux.intel.com> (raw)
In-Reply-To: <20131118152806.GB19649@infradead.org>
On 11/18/2013 07:28 AM, Christoph Hellwig wrote:
> On Fri, Nov 15, 2013 at 04:09:18PM -0800, David Cohen wrote:
>> This patch adds a test module to validate sfi_device() when used from a
>> driver module.
>
> I don't think this is all that useful. How about you prepeare a few
> of the more useful drivers from your tree for submission instead?
One of these drivers you can track here:
https://patchwork.kernel.org/patch/3109791/
This is necessary to enable serial console on Saltbay (Merrifield based
platform). But the driver is still being reworked to be upstreamed.
Anyway, upstream those drivers won't work to validate this patch set
we're discussion here. All platform codes are bool (can't be module).
The real purpose of these patches is to make my internal tree to be
equal to upstream. My intention is to upstream *all* internal patches
of Intel MID and temporarily move away from arch/x86/platform/intel-
mid/device_libs/ the platform code from still-on-staging-state drivers.
So, we need a dummy module on upstream to make this code testable.
In case this code is not accepted, I'll will have to maintain 2
official public branches: one with these patches and one without them.
Br, David
next prev parent reply other threads:[~2013-11-18 17:37 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-12 22:13 [PATCH 0/3] Bring SFI support to out-of-tree driver modules on Intel Mid David Cohen
2013-11-12 22:13 ` [PATCH 1/3] sfi: add private data to sfi_parse_table() David Cohen
2013-11-12 22:13 ` [PATCH 2/3] x86: intel-mid: struct devs_id.name should have 'SFI_NAME_LEN' length David Cohen
2013-11-12 22:13 ` [PATCH 3/3] x86: intel-mid: allow sfi_device() to be used by modules David Cohen
2013-11-13 8:14 ` [PATCH 0/3] Bring SFI support to out-of-tree driver modules on Intel Mid Christoph Hellwig
2013-11-13 11:19 ` Ingo Molnar
2013-11-13 18:10 ` David Cohen
2013-11-15 22:25 ` David Cohen
2013-11-13 19:29 ` [PATCH] x86: intel-mid: add test module for sfi_device() David Cohen
2013-11-13 19:31 ` David Cohen
2013-11-16 0:09 ` [PATCH v1.1] " David Cohen
2013-11-18 15:28 ` Christoph Hellwig
2013-11-18 17:35 ` David Cohen [this message]
2013-11-18 17:37 ` David Cohen
2013-11-21 18:25 ` David Cohen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=528A4FED.3030709@linux.intel.com \
--to=david.a.cohen@linux.intel.com \
--cc=hch@infradead.org \
--cc=hpa@zytor.com \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).