Re: [PATCH v2] power: Replace printks with dev_* and pr_* routines

[Shuah Khan <shuah.kh@samsung.com>]

On 11/19/2013 11:53 AM, Joe Perches wrote:
> On Tue, 2013-11-19 at 11:46 -0700, Shuah Khan wrote:
>> Replaced printks with dev_* and pr_* routines. Replacing printk in
>> __suspend_report_result() will require passing in struct device *
>> pointer from calling routines and this will require changes to
>> external interface suspend_report_result() which is used by several
>> drivers. Hence, this one instance is replaced by pr_err().
> []
>> diff --git a/drivers/base/power/main.c b/drivers/base/power/main.c
> []
>> @@ -1308,9 +1308,8 @@ int dpm_prepare(pm_message_t state)
>>   				error = 0;
>>   				continue;
>>   			}
>> -			printk(KERN_INFO "PM: Device %s not prepared "
>> -				"for power transition: code %d\n",
>> -				dev_name(dev), error);
>> +			dev_info("PM: not prepared for power transition: ",
>> +				 "code %d\n", error);
>
> Shuah, you have to make sure the files modified by
> your patches compile successfully before sending
> patches like this.
>
>

Oops. I did compile. Missed the warning. Sorry about that.

-- Shuah

-- 
Shuah Khan
Senior Linux Kernel Developer - Open Source Group
Samsung Research America(Silicon Valley)
shuah.kh@samsung.com | (970) 672-0658