From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750879Ab3KTFyA (ORCPT ); Wed, 20 Nov 2013 00:54:00 -0500 Received: from mail-qe0-f46.google.com ([209.85.128.46]:62690 "EHLO mail-qe0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750854Ab3KTFx6 (ORCPT ); Wed, 20 Nov 2013 00:53:58 -0500 Message-ID: <528C4E6F.20507@linaro.org> Date: Wed, 20 Nov 2013 11:23:51 +0530 From: viresh kumar User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 MIME-Version: 1.0 To: rjw@rjwysocki.net CC: linaro-kernel@lists.linaro.org, patches@linaro.org, cpufreq@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, nm@ti.com, shawn.guo@linaro.org, ceh@ti.com, Viresh Kumar Subject: Re: [PATCH] cpufreq/stats: Add "unknown" frequency field in stats tables References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday 19 November 2013 11:10 AM, Viresh Kumar wrote: > diff --git a/drivers/cpufreq/cpufreq_stats.c b/drivers/cpufreq/cpufreq_stats.c > index 4cf0d28..ebb21cd 100644 > --- a/drivers/cpufreq/cpufreq_stats.c > +++ b/drivers/cpufreq/cpufreq_stats.c > @@ -72,9 +72,13 @@ static ssize_t show_time_in_state(struct cpufreq_policy *policy, char *buf) > return 0; > cpufreq_stats_update(stat->cpu); > for (i = 0; i < stat->state_num; i++) { > - len += sprintf(buf + len, "%u %llu\n", stat->freq_table[i], > - (unsigned long long) > - jiffies_64_to_clock_t(stat->time_in_state[i])); > + if (stat->freq_table[i] == -1) > + return sprintf(buf + len, "unknown"); > + else > + return sprintf(buf + len, "%u", stat->freq_table[i]); > + > + len += sprintf(buf + len, " %llu\n", (unsigned long long) > + jiffies_64_to_clock_t(stat->time_in_state[i])); > } > return len; Somehow I forgot to add below fix with this patch, which I have tested at that time. diff --git a/drivers/cpufreq/cpufreq_stats.c b/drivers/cpufreq/cpufreq_stats.c index ebb21cd..89012d1 100644 --- a/drivers/cpufreq/cpufreq_stats.c +++ b/drivers/cpufreq/cpufreq_stats.c @@ -73,9 +73,9 @@ static ssize_t show_time_in_state(struct cpufreq_policy *policy, char *buf) cpufreq_stats_update(stat->cpu); for (i = 0; i < stat->state_num; i++) { if (stat->freq_table[i] == -1) - return sprintf(buf + len, "unknown"); + len+= sprintf(buf + len, "unknown"); else - return sprintf(buf + len, "%u", stat->freq_table[i]); + len+= sprintf(buf + len, "%u", stat->freq_table[i]); len += sprintf(buf + len, " %llu\n", (unsigned long long) jiffies_64_to_clock_t(stat->time_in_state[i]));