From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752421Ab3KTJE7 (ORCPT ); Wed, 20 Nov 2013 04:04:59 -0500 Received: from comal.ext.ti.com ([198.47.26.152]:51297 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750860Ab3KTJEs (ORCPT ); Wed, 20 Nov 2013 04:04:48 -0500 Message-ID: <528C7B0E.3080401@ti.com> Date: Wed, 20 Nov 2013 14:34:14 +0530 From: Kishon Vijay Abraham I User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 MIME-Version: 1.0 To: Vivek Gautam CC: Jingoo Han , Kamil Debski , Vivek Gautam , Linux USB Mailing List , "linux-samsung-soc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , , Greg KH , Kukjin Kim , Sylwester Nawrocki , Tomasz Figa , Felipe Balbi , Julius Werner Subject: Re: [PATCH RFC 1/4] phy: Add new Exynos5 USB 3.0 PHY driver References: <1383205544-32244-1-git-send-email-gautam.vivek@samsung.com> <1383205544-32244-2-git-send-email-gautam.vivek@samsung.com> <527744B2.4090303@ti.com> <030d01ced946$d6e23490$84a69db0$%debski@samsung.com> <52779D28.9000905@ti.com> <00fe01ceda0a$941957a0$bc4c06e0$%debski@samsung.com> <000001ceda17$f41c2030$dc546090$%han@samsung.com> <000101ceda1f$04ca6f20$0e5f4d60$%han@samsung.com> <000301ceda84$1d648bf0$582da3d0$%han@samsung.com> <5280BB65.5040305@ti.com> In-Reply-To: Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday 20 November 2013 02:27 PM, Vivek Gautam wrote: > Hi Kishon, > > > On Mon, Nov 11, 2013 at 4:41 PM, Kishon Vijay Abraham I wrote: >> Hi, > sorry for the delayed response. > >> >> On Wednesday 06 November 2013 05:37 AM, Jingoo Han wrote: >>> On Wednesday, November 06, 2013 2:58 AM, Vivek Gautam wrote: >>>> On Tue, Nov 5, 2013 at 5:33 PM, Jingoo Han wrote: >>> >>> [.....] >>> >>>>> USB3.0 PHY consists of two blocks such as 3.0 block and 2.0 block. >>>>> This USB3.0 PHY can support UTMI+ and PIPE3 interface for 3.0 block >>>>> and 2.0 block, respectively. >>>>> >>>>> Conclusion: >>>>> >>>>> 1) USB2.0 PHY: USB2.0 HOST, USB2.0 Device >>>>> Base address: 0x1213 0000 >>>>> >>>>> 2) USB3.0 PHY: USB3.0 DRD (3.0 HOST & 3.0 Device) >>>>> Base address: 0x1210 0000 >>>>> 2.0 block(UTMI+) & 3.0 block(PIPE3) >>>> >>>> And this is of course the PHY used by DWC3 controller, which works at >>>> both High speed as well as Super Speed. >>>> Right ? >>> >>> Right. >>> >>> While 3.0 block(PIPE3) can be used for Super Speed, 2.0 block(UTMI+) >>> can be used for High speed. >> >> It should then come under *single IP muliple PHY* category similar to what >> Sylwester has done. > > Do you mean that i should be including PHY IDs for UTMI+ phy and PIPE3 > phy present in this PHY block ? > AFAICS the two phys (UTMI+ and PIPE3) do not really have separate > registers to program, and that's the reason > we program the entire PHY in a shot. you mean you program the same set of bits for UTMI+ and PIPE3? Thanks Kishon