public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: David Ahern <dsahern@gmail.com>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: acme@ghostprotocols.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf script: Print callchains and symbols if they exist - v2
Date: Wed, 20 Nov 2013 07:09:38 -0700	[thread overview]
Message-ID: <528CC2A2.6000403@gmail.com> (raw)
In-Reply-To: <20131120130426.GB308@localhost.localdomain>

On 11/20/13, 6:04 AM, Frederic Weisbecker wrote:

> We probably want to avoid DSO and IP for most tracepoints. For kernel
> tracepoints dso is going to be the kernel anyway and IP is often not that relevant
> either.

Sorry, you mentioned that last time and I forgot to respond.

Yes, there are a number of tracepoints that are completely kernel side 
and possibly uninteresting callstacks. There are others that are 
triggered in process context and you want to see the stacks all the way 
back to main. I would hope that users are adding -g to record only when 
it is truly wanted. Given that the idea of perf-script is to print data 
in a file why not dump everything in the file - address, dso, and 
symbol. There is always -G to suppress the callchains.

As an example it is useful to see the overhead of 'perf sched record 
-g': all I really want is callchains on sched_switch, and the callchains 
on sched_stat_runtime and wakeup are huge emphasizing the need to 
specify events where callchains are interesting and not collect them on 
others and that steps into the pandora's box of mixed sample types.

David


  reply	other threads:[~2013-11-20 14:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-20  4:07 [PATCH] perf script: Print callchains and symbols if they exist - v2 David Ahern
2013-11-20 13:04 ` Frederic Weisbecker
2013-11-20 14:09   ` David Ahern [this message]
2013-11-30 12:52 ` [tip:perf/core] perf script: Print callchains and symbols if they exist tip-bot for David Ahern

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=528CC2A2.6000403@gmail.com \
    --to=dsahern@gmail.com \
    --cc=acme@ghostprotocols.net \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox