Support for ARM architected timer event stream generation on x86

Support for ARM architected timer event stream generation on x86

[Pavel Machek]

Hi!

On x86, I get asked if I want to support arm architectured
timer. That's not exactly clever question... right?

I'd say it is from this merge... please fix.
								Pavel

commit 191124efb4d6e5e47fe073b4b97350873523e88c
Merge: 68e9074 346e748
Author: Daniel Lezcano <daniel.lezcano@linaro.org>
Date:   Thu Oct 3 16:13:51 2013 +0200

    Merge branch 'timer_evtstrm' of git://linux-arm.org/linux-skn into
    clockevents/3.13
    


-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[PATCH] drivers: clocksource: Hide arm_arch_timer eventstream Kconfig on non-ARM

[Stephen Boyd]

Pavel Machek reports that this config is exposed on x86 where the
ARM architected timers aren't even present. Make it depend on the
ARM architected timers being selected so that non-ARM builds
aren't asked about it.

Reported-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
---
 drivers/clocksource/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
index bdb953e..5c07a56 100644
--- a/drivers/clocksource/Kconfig
+++ b/drivers/clocksource/Kconfig
@@ -87,6 +87,7 @@ config ARM_ARCH_TIMER
 config ARM_ARCH_TIMER_EVTSTREAM
 	bool "Support for ARM architected timer event stream generation"
 	default y if ARM_ARCH_TIMER
+	depends on ARM_ARCH_TIMER
 	help
 	  This option enables support for event stream generation based on
 	  the ARM architected timer. It is used for waking up CPUs executing
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation

Re: [PATCH] drivers: clocksource: Hide arm_arch_timer eventstream Kconfig on non-ARM

[Pavel Machek]

On Wed 2013-11-20 12:02:03, Stephen Boyd wrote:
> Pavel Machek reports that this config is exposed on x86 where the
> ARM architected timers aren't even present. Make it depend on the
> ARM architected timers being selected so that non-ARM builds
> aren't asked about it.
> 
> Reported-by: Pavel Machek <pavel@ucw.cz>
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>

Reviewed-by: Pavel Machek <pavel@ucw.cz>

Thanks!
								Pavel
								
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Re: [PATCH] drivers: clocksource: Hide arm_arch_timer eventstream Kconfig on non-ARM

[Daniel Lezcano]

On 11/20/2013 10:09 PM, Pavel Machek wrote:
> On Wed 2013-11-20 12:02:03, Stephen Boyd wrote:
>> Pavel Machek reports that this config is exposed on x86 where the
>> ARM architected timers aren't even present. Make it depend on the
>> ARM architected timers being selected so that non-ARM builds
>> aren't asked about it.
>>
>> Reported-by: Pavel Machek <pavel@ucw.cz>
>> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
>
> Reviewed-by: Pavel Machek <pavel@ucw.cz>
>
> Thanks!

Applied to my tree as a 3.13 fix.

Thanks Stephen and Pavel !

   -- Daniel

-- 
  <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

Re: [PATCH] drivers: clocksource: Hide arm_arch_timer eventstream Kconfig on non-ARM

[Takashi Iwai]

At Wed, 20 Nov 2013 12:02:03 -0800,
Stephen Boyd wrote:
> 
> Pavel Machek reports that this config is exposed on x86 where the
> ARM architected timers aren't even present. Make it depend on the
> ARM architected timers being selected so that non-ARM builds
> aren't asked about it.
> 
> Reported-by: Pavel Machek <pavel@ucw.cz>
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
> ---
>  drivers/clocksource/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
> index bdb953e..5c07a56 100644
> --- a/drivers/clocksource/Kconfig
> +++ b/drivers/clocksource/Kconfig
> @@ -87,6 +87,7 @@ config ARM_ARCH_TIMER
>  config ARM_ARCH_TIMER_EVTSTREAM
>  	bool "Support for ARM architected timer event stream generation"
>  	default y if ARM_ARCH_TIMER
> +	depends on ARM_ARCH_TIMER

We can drop "if ARM_ARCH_TIMER" in "default y" line now.
But do we need "default y" at the first place?


Takashi