From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753842Ab3KUIgO (ORCPT ); Thu, 21 Nov 2013 03:36:14 -0500 Received: from bear.ext.ti.com ([192.94.94.41]:53656 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750941Ab3KUIgM (ORCPT ); Thu, 21 Nov 2013 03:36:12 -0500 Message-ID: <528DC5DD.8040801@ti.com> Date: Thu, 21 Nov 2013 14:05:41 +0530 From: Mugunthan V N User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 MIME-Version: 1.0 To: Sebastian Hesselbarth CC: "David S. Miller" , , , Subject: Re: [PATCH RFC v1 7/7] net: cpsw: resume/suspend PHY on port start/stop References: <1384978913-8052-1-git-send-email-sebastian.hesselbarth@gmail.com> <1384978913-8052-8-git-send-email-sebastian.hesselbarth@gmail.com> In-Reply-To: <1384978913-8052-8-git-send-email-sebastian.hesselbarth@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday 21 November 2013 01:51 AM, Sebastian Hesselbarth wrote: > Network PHYs consume a noticable amount of power. This adds phy_resume > on slave_open and phy_suspend on slave_stop to save this power if the > port is down anyway. > > Signed-off-by: Sebastian Hesselbarth > --- > Cc: David S. Miller > Cc: netdev@vger.kernel.org > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > --- > drivers/net/ethernet/ti/cpsw.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c > index 90d41d2..f1dc54f 100644 > --- a/drivers/net/ethernet/ti/cpsw.c > +++ b/drivers/net/ethernet/ti/cpsw.c > @@ -1013,6 +1013,7 @@ static void cpsw_slave_open(struct cpsw_slave *slave, struct cpsw_priv *priv) > } else { > dev_info(priv->dev, "phy found : id is : 0x%x\n", > slave->phy->phy_id); > + phy_resume(slave->phy); > phy_start(slave->phy); > > /* Configure GMII_SEL register */ > @@ -1081,6 +1082,7 @@ static void cpsw_slave_stop(struct cpsw_slave *slave, struct cpsw_priv *priv) > if (!slave->phy) > return; > phy_stop(slave->phy); > + phy_suspend(slave->phy); > phy_disconnect(slave->phy); > slave->phy = NULL; > } Can these be called from phy_start and phy_stop itself so that it reduces the effort of patching all drivers and also applies to all etherent drivers. Regards Mugunthan V N