linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Cohen <david.a.cohen@linux.intel.com>
To: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: linux-kbuild@vger.kernel.org,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	mmarek@suse.cz, rostedt@goodmis.org
Subject: Re: make oldnoconfig fix?
Date: Thu, 21 Nov 2013 10:36:56 -0800	[thread overview]
Message-ID: <528E52C8.5000508@linux.intel.com> (raw)
In-Reply-To: <52812829.4080508@linux.intel.com>

On 11/11/2013 10:55 AM, David Cohen wrote:
> On 11/11/2013 10:13 AM, Yann E. MORIN wrote:
>> David, All,
> 
> Hi Yann,
> 
>>
>> On 2013-11-11 10:11 -0800, David Cohen spake thusly:
>>> Is there a plan to fix 'make oldnoconfig' option?
>>> I currently have need to it :)
>>> I've tracked a thread fixing 'make olddefconfig' where 'oldnoconfig'
>>> option is reported as a known bug, right?
>>
>> Sorry, I don't understand what your problem is.
> 
> Maybe I assumed it was more 'known' then it actually is :)
> 
>>
>> Care to explain in details what problem you have:
>>    - what you start with
>>    - what you do
>>    - what you get
>>    - what you expected
> 
> The bug with 'oldnoconfig' is: 'make oldnoconfig' is just an alias to
> 'olddefconfig'. Any non-existent config is defined with its default
> value instead of 'N'.
> 
> I work with embedded platforms. I need to maintain a set of defconfigs
> for different products (customers some times want tailored configs, so
> creating a generic one isn't an option always).
> 
> In order to have full control of the .config generated out of
> defconfigs, I don't allow any CONFIG_ to be selected implicitly. So
> everytime a Kconfig is changed in our internal tree, we need to update
> all defconfigs either with CONFIG_... = [y|n] or # CONFIG_... is not set
> 
> If I managed to get 'make oldnoconfig' working, I could not care about
> # CONFIG_... is not set and internal and changes to defconfigs would be
> easily to understand and review.
> 
>>
>> So we can try to reproduce the issue and investigate what is wrong.
> 
> All we need to know is explained in this commit:
> 
> commit fb16d8912db5268f29706010ecafff74b971c58d
> Author: Adam Lee <adam8157@gmail.com>
> Date:   Sat Sep 1 01:05:17 2012 +0800
> 
>     kconfig: replace 'oldnoconfig' with 'olddefconfig', and keep the old
> name as an alias
> 
>     As 67d34a6a391369269a2e5dba8a5f42cc4cd50231 said, 'oldnoconfig' doesn't
>     set new symbols to 'n', but instead sets it to their default values.
> 
>     So, this patch replaces 'oldnoconfig' with 'olddefconfig', stop making
>     people confused, and keep the old name 'oldnoconfig' as an alias,
>     because people already are dependent on its behavior with the
>     counter-intuitive name.
> 
>     Signed-off-by: Adam Lee <adam8157@gmail.com>
>     Signed-off-by: Michal Marek <mmarek@suse.cz>
> 
> 
>>
>> Since you mention an existing thread, please add a pointer (URL) to
>> this thread in the archives (Use: http://marc.info/?l=linux-kbuild ).
> 
> This is the thread I was talking about:
> http://comments.gmane.org/gmane.linux.kbuild.devel/8560
> 
> Master Yoda promised to fix it when the problem gets bigger :)

Any comments here? :)

Br, David Cohen

  reply	other threads:[~2013-11-21 18:32 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-11 18:11 make oldnoconfig fix? David Cohen
2013-11-11 18:13 ` Yann E. MORIN
2013-11-11 18:55   ` David Cohen
2013-11-21 18:36     ` David Cohen [this message]
2013-12-03  2:58     ` Rob Landley
2013-12-06  0:10       ` David Cohen
2013-12-23  5:42         ` Rob Landley
2013-11-11 18:20 ` Felipe Contreras
2013-11-11 18:40   ` David Cohen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=528E52C8.5000508@linux.intel.com \
    --to=david.a.cohen@linux.intel.com \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mmarek@suse.cz \
    --cc=rostedt@goodmis.org \
    --cc=yann.morin.1998@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).